-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure psql #22
Azure psql #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick first pass; did not try to install the package yet. Will test with that tomorrow.
bundles/azure/aso/psql/bundle/config/01-flexible-server.ytt.yml
Outdated
Show resolved
Hide resolved
bundles/azure/aso/psql/bundle/config/01-flexible-server.ytt.yml
Outdated
Show resolved
Hide resolved
bundles/azure/aso/psql/bundle/config/01-flexible-server.ytt.yml
Outdated
Show resolved
Hide resolved
bundles/azure/aso/psql/bundle/config/01-flexible-server.ytt.yml
Outdated
Show resolved
Hide resolved
bundles/azure/aso/psql/bundle/config/01-flexible-server.ytt.yml
Outdated
Show resolved
Hide resolved
bundles/azure/aso/psql/bundle/config/01-flexible-server.ytt.yml
Outdated
Show resolved
Hide resolved
bundles/azure/aso/psql/bundle/config/01-flexible-server.ytt.yml
Outdated
Show resolved
Hide resolved
bundles/azure/aso/psql/bundle/config/01-flexible-server.ytt.yml
Outdated
Show resolved
Hide resolved
bundles/azure/aso/psql/bundle/config/01-flexible-server.ytt.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to change the couple of missed namespace things. Else are just nits.
eb1e923
to
765db87
Compare
The Azure psql package has been published in this org's gh packages. The reference to it has been correctly resolved in the package.yml file for the repo which has then been published with version 0.0.3 and tested. |
@@ -0,0 +1,3 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion Could you add to the README.md to include the new Azure Postgres?
b891987
to
45b4c2e
Compare
45b4c2e
to
83e3f53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Adding a reference package for Azure FlexibleServer with PostgreSQL as implementation.