Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure psql #22

Merged
merged 4 commits into from
Sep 27, 2022
Merged

Azure psql #22

merged 4 commits into from
Sep 27, 2022

Conversation

joostvdg
Copy link
Contributor

Adding a reference package for Azure FlexibleServer with PostgreSQL as implementation.

Copy link
Contributor

@hoegaarden hoegaarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick first pass; did not try to install the package yet. Will test with that tomorrow.

bundles/azure/aso/psql/bundle/config/00-schema.yml Outdated Show resolved Hide resolved
bundles/azure/aso/psql/bundle/config/00-schema.yml Outdated Show resolved Hide resolved
bundles/azure/aso/psql/bundle/config/00-schema.yml Outdated Show resolved Hide resolved
repository/packages/azure/psql/0.16.0.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@hoegaarden hoegaarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to change the couple of missed namespace things. Else are just nits.

@matteo-magni matteo-magni marked this pull request as ready for review September 26, 2022 13:14
@matteo-magni
Copy link
Contributor

The Azure psql package has been published in this org's gh packages. The reference to it has been correctly resolved in the package.yml file for the repo which has then been published with version 0.0.3 and tested.

@@ -0,0 +1,3 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion Could you add to the README.md to include the new Azure Postgres?

Copy link
Contributor

@bzhtux bzhtux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@hoegaarden hoegaarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hoegaarden hoegaarden merged commit 0cede43 into main Sep 27, 2022
@matteo-magni matteo-magni deleted the azure-psql branch September 27, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants