Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add ROCm Docker Build #2886

Merged
merged 31 commits into from
Mar 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
cfba4cd
CI: Add ROCm Docker Build
simon-mo Feb 15, 2024
d237ff6
fix name
simon-mo Feb 15, 2024
03aba6b
move
simon-mo Feb 15, 2024
e226c59
Add sanity test
simon-mo Feb 20, 2024
51d2d75
Add sanity test
simon-mo Feb 20, 2024
5a70ad7
remove only the rocm container
simon-mo Feb 20, 2024
2156f9e
Merge branch 'main' of github.com:vllm-project/vllm into rcom-ci
simon-mo Mar 8, 2024
cd910dc
migrate to buildkite
simon-mo Mar 8, 2024
1c872cb
change to shell script
simon-mo Mar 15, 2024
e1d886f
fix typo
simon-mo Mar 15, 2024
4d87cec
fix typo
simon-mo Mar 15, 2024
456b76b
fix docker command
simon-mo Mar 15, 2024
cb7989a
fix docker command
simon-mo Mar 15, 2024
7a60114
fix docker command
simon-mo Mar 15, 2024
7367304
run docker sync
simon-mo Mar 15, 2024
ff78d36
add cmd
simon-mo Mar 15, 2024
2c5277e
Merge branch 'main' of github.com:vllm-project/vllm into rcom-ci
simon-mo Mar 15, 2024
21b0dbb
add outlines
simon-mo Mar 15, 2024
fe983cc
Revert "Dynamically configure shared memory size for moe_align_block_…
simon-mo Mar 16, 2024
822bffd
add debug info
simon-mo Mar 16, 2024
0125268
use test server due to outlines issue
simon-mo Mar 16, 2024
5e3180d
actually use gpus
simon-mo Mar 16, 2024
fbc07a9
use rocm docker
simon-mo Mar 16, 2024
83447e4
use better healthcheck
simon-mo Mar 16, 2024
1117e46
use curl on host instead
simon-mo Mar 16, 2024
1d8911f
fix curl
simon-mo Mar 16, 2024
ec2d7ec
reset tests
simon-mo Mar 16, 2024
94fa91d
newline
simon-mo Mar 16, 2024
c5850ad
add comments
simon-mo Mar 16, 2024
4a88632
Revert "Revert "Dynamically configure shared memory size for moe_alig…
simon-mo Mar 18, 2024
06f9ccf
Merge branch 'main' of github.com:vllm-project/vllm into rcom-ci
simon-mo Mar 18, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions .buildkite/run-amd-test.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
# This script build the ROCm docker image and run the API server inside the container.
# It serves a sanity check for compilation and basic model usage.
set -ex

# Print ROCm version
rocminfo

# Try building the docker image
docker build -t rocm -f Dockerfile.rocm .

# Setup cleanup
remove_docker_container() { docker rm -f rocm || true; }
trap remove_docker_container EXIT
remove_docker_container

# Run the image
docker run --device /dev/kfd --device /dev/dri --network host --name rocm rocm python3 -m vllm.entrypoints.api_server &

# Wait for the server to start
wait_for_server_to_start() {
timeout=300
counter=0

while [ "$(curl -s -o /dev/null -w ''%{http_code}'' localhost:8000/health)" != "200" ]; do
sleep 1
counter=$((counter + 1))
if [ $counter -ge $timeout ]; then
echo "Timeout after $timeout seconds"
break
fi
done
}
wait_for_server_to_start

# Test a simple prompt
curl -X POST -H "Content-Type: application/json" \
localhost:8000/generate \
-d '{"prompt": "San Francisco is a"}'
5 changes: 5 additions & 0 deletions .buildkite/test-template.j2
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
{% set default_working_dir = "/vllm-workspace/tests" %}

steps:
- label: "AMD Test"
agents:
queue: amd
command: bash .buildkite/run-amd-test.sh

- label: ":docker: build image"
commands:
- "docker build --build-arg max_jobs=16 --tag {{ docker_image }} --target test --progress plain ."
Expand Down
1 change: 1 addition & 0 deletions requirements-rocm.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@ fastapi
uvicorn[standard]
pydantic >= 2.0 # Required for OpenAI server.
prometheus_client >= 0.18.0
outlines == 0.0.34
Loading