CI: Add ROCm Docker Build #2886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…size_kernel (vllm-project#3376)" This reverts commit 78b6c48.
|
For a green build, see https://buildkite.com/vllm/ci/builds/2766#018e44be-10d1-42a6-a20b-056d24e35d3e/24-496 |
WoosukKwon
reviewed
Mar 18, 2024
csrc/moe_align_block_size_kernels.cu
Outdated
There was a problem hiding this comment.
Why is this file reverted?
There was a problem hiding this comment.
Oh I just saw the PR description. I believe this can be easily fixed.
There was a problem hiding this comment.
@simon-mo Do you mind if I directly push a change to fix the kernel compilation error?
There was a problem hiding this comment.
Oh just created a new PR #3470 to get reviewed.
There was a problem hiding this comment.
I merged #3470 Can you please rebase the PR with the current main branch?
…n_block_size_kernel (vllm-project#3376)"" This reverts commit fe983cc.
WoosukKwon
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Buildkite CI for AMD build that test the compilation and running a simple model using api server.
It reverted #3376 because it doesn't compile on AMD. (I will leave a message to the original PR after merge)
Another known issue is that our structured generation library doesn't work on AMD for some reason. See #3280.
But I think this PR has high priority for future build (CMake) and catching compatibility issue.