-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model]: Add support for Aria model #10514
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments.
56090fb
to
a0ebc3a
Compare
Signed-off-by: xffxff <[email protected]>
Signed-off-by: xffxff <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the example code to offline_inference_vision_language.py
? If Aria supports multi-images inputs, we need to add a multi-images example to offline_inference_vision_language_multi_image.py
as well.
Otherwise overall looks good. Just need a minor modification.
Co-authored-by: Isotr0py <[email protected]>
Signed-off-by: xffxff <[email protected]>
Signed-off-by: xffxff <[email protected]>
Yes @ywang96 I’d be happy to work on the refactoring. I noticed a warning about using legacy input pipeline and had tried switching to the new multi-modal processor, but I couldn’t find any examples at the time and decided to hold off. Now that I can refer to your work in #10570, I’ll update my PR to align with the new interface. |
Signed-off-by: xffxff <[email protected]>
Signed-off-by: xffxff <[email protected]>
Sure! I'll add some examples |
Signed-off-by: xffxff <[email protected]>
Signed-off-by: xffxff <[email protected]>
Signed-off-by: xffxff <[email protected]>
Done! Please take a look @Isotr0py |
I’ve updated my PR to follow the new interface—just needed to make a few changes.
@ywang96 Apologies for the confusion earlier; I initially thought your refactoring was related to #10114 and didn’t look closely at your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now! Thanks for supporting this!
Thank you so much for your patience! @Isotr0py! |
Please fix the error in models tests. |
Signed-off-by: Isotr0py <[email protected]>
Oh... just realized that we don't have models tests for this yet. @Isotr0py do you have time to add one? |
Hmmm, this model is a large model might need 80G A100 for running. Not sure if I can get such an idle card for testing these days. 😅 Update: I just found a FP8-dynamic quantization for aria: thwin27/Aria-sequential_mlp-FP8-dynamic. Perhaps I can test with this model. |
@Isotr0py I’m happy to help with adding tests! It would be great if there are some examples I could refer to. |
@xffxff Thank you very much! You can just add a test setting for this model in pytest -s -v tests/models/decoder_only/vision_language/test_models.py -k aria You can refer to other models's settings there: vllm/tests/models/decoder_only/vision_language/test_models.py Lines 119 to 135 in 9e0a147
|
Signed-off-by: xffxff <[email protected]> Co-authored-by: Isotr0py <[email protected]> Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: xffxff <[email protected]> Co-authored-by: Isotr0py <[email protected]>
Add support for rhymes-ai/Aria, a multimodal MoE model.
Feel free to request changes!
You can try it with the following code: