Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] fix aria model and add torch.compile #10645

Merged
merged 1 commit into from
Nov 26, 2024
Merged

[bugfix] fix aria model and add torch.compile #10645

merged 1 commit into from
Nov 26, 2024

Conversation

youkaichao
Copy link
Member

No description provided.

@youkaichao
fix aria model
d42d04f 
Signed-off-by: youkaichao <[email protected]>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

youkaichao
youkaichao commented Nov 25, 2024
View reviewed changes
vllm/model_executor/models/aria.py
quant_config = vllm_config.quant_config

# FIXME: this is a hack to disable the compilation of the model
self.do_not_compile = True
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xffxff why do you want to disable it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it, and it can use torch.compile .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I encountered an error at the start of my PR: 'AriaMoELMModel' object has no attribute 'do_not_compile'. I didn’t investigate it further, as it might not be necessary right now. It’s great to see that we can now use torch.compile!

@youkaichao
Copy link
Member Author

the tests in #10514 pass because it does not merge main.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 26, 2024 01:49
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 26, 2024
@youkaichao youkaichao disabled auto-merge November 26, 2024 02:31
@youkaichao
Copy link
Member Author

merge as Basic Models Test passes

@youkaichao youkaichao merged commit 45ac4ff into vllm-project:main Nov 26, 2024
60 of 65 checks passed
@youkaichao youkaichao deleted the fix_aria branch November 26, 2024 02:32
afeldman-nm pushed a commit to neuralmagic/vllm that referenced this pull request Dec 2, 2024
@youkaichao @afeldman-nm
[bugfix] fix aria model and add torch.compile (vllm-project#10645)
ea0c690 
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@youkaichao
[bugfix] fix aria model and add torch.compile (vllm-project#10645)
f8ec7d8 
Signed-off-by: youkaichao <[email protected]>
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
@youkaichao @BKitor
[bugfix] fix aria model and add torch.compile (vllm-project#10645)
42e6bb3 
Signed-off-by: youkaichao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xffxff xffxff xffxff left review comments

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@Isotr0py Isotr0py Awaiting requested review from Isotr0py

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youkaichao @xffxff @DarkLight1337