-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy to npm on release branch #41
Conversation
.travis.yml
Outdated
api_key: $NPM_DEPLOY_API_KEY | ||
on: | ||
branch: release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can prepare releases on a release branch but then merge it to master
which will trigger a deployment.
Also, there has to be a process in place to bump the versions up, otherwise it will fail to deploy.
581f13c
to
984ec10
Compare
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
==========================================
+ Coverage 84.61% 86.17% +1.55%
==========================================
Files 4 4
Lines 91 94 +3
Branches 16 17 +1
==========================================
+ Hits 77 81 +4
Misses 8 8
+ Partials 6 5 -1
Continue to review full report at Codecov.
|
What's this PR do?
It should automatically deploy to NPM when we merge to a release branch (to be created).
I followed these instructions: https://docs.travis-ci.com/user/deployment/npm/
Where should the reviewer start?
How should this be manually tested?
Well, either...
Any preference?
What are the relevant tickets / issues?
#40