Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy to npm on release branch #41

Merged
merged 2 commits into from
Mar 23, 2018

Conversation

mattdell
Copy link
Collaborator

@mattdell mattdell commented Mar 22, 2018

What's this PR do?

It should automatically deploy to NPM when we merge to a release branch (to be created).

I followed these instructions: https://docs.travis-ci.com/user/deployment/npm/

Where should the reviewer start?

  • travis.yml

How should this be manually tested?

Well, either...

  • Change the branch name to this branch to see if it works
  • Merge to master, then merge master to release to see if it works

Any preference?

What are the relevant tickets / issues?

#40

.travis.yml Outdated
api_key: $NPM_DEPLOY_API_KEY
on:
branch: release
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variables have been added...

screen shot 2018-03-22 at 18 10 49

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can prepare releases on a release branch but then merge it to master which will trigger a deployment.
Also, there has to be a process in place to bump the versions up, otherwise it will fail to deploy.

@coveralls
Copy link

coveralls commented Mar 22, 2018

Coverage Status

Coverage remained the same at 84.8% when pulling 984ec10 on issue/40-use-release-branch-deploy-npm into ab56537 on master.

@vitkon vitkon force-pushed the issue/40-use-release-branch-deploy-npm branch from 581f13c to 984ec10 Compare March 23, 2018 18:55
@codecov-io
Copy link

codecov-io commented Mar 23, 2018

Codecov Report

Merging #41 into master will increase coverage by 1.55%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   84.61%   86.17%   +1.55%     
==========================================
  Files           4        4              
  Lines          91       94       +3     
  Branches       16       17       +1     
==========================================
+ Hits           77       81       +4     
  Misses          8        8              
+ Partials        6        5       -1
Impacted Files Coverage Δ
src/validators.ts 100% <0%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab56537...984ec10. Read the comment docs.

@vitkon vitkon merged commit 5f88f38 into master Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants