Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: working off a release branch #40

Open
vitkon opened this issue Mar 22, 2018 · 7 comments
Open

Discussion: working off a release branch #40

vitkon opened this issue Mar 22, 2018 · 7 comments
Assignees

Comments

@vitkon
Copy link
Owner

vitkon commented Mar 22, 2018

Problem: how do we make sure that the latest code in master resembles what's in npm?

@mattdell
Copy link
Collaborator

Should be easy enough: https://docs.travis-ci.com/user/deployment/npm/

Though need to think about what the keys are going to be as it seems they have to be checked in 🤔

@mattdell
Copy link
Collaborator

Thoughts on #41 ?

@mattdell
Copy link
Collaborator

Also it's an interesting approach to use the deploy trigger when there's a tag: https://docs.travis-ci.com/user/deployment/npm/#What-to-release

(creating these on github would cause a deployment, for example)

@vitkon
Copy link
Owner Author

vitkon commented Mar 22, 2018

tag sounds like a legit trigger to me

@vitkon
Copy link
Owner Author

vitkon commented Mar 22, 2018

btw, https://github.com/sindresorhus/np with --yolo option :)

@vitkon
Copy link
Owner Author

vitkon commented Mar 22, 2018

to summarise, here's the suggested release process:

  1. set up travis to deploy on a new tag
  2. Continue to work off master
  3. When release is ready to cut, use np tool with --no-publish (npm script shortcut)
  4. push tags to origin

@mattdell
Copy link
Collaborator

I like it! Will look into it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants