Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow enabling esbuild.minifyWhitespace for es format in lib mode (fix #6555) #18737

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: allow enabling esbuild.minifyWhitespace for es format in lib mode (fix #6555) #18737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/config/build-options.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ During the SSR build, static assets aren't emitted as it is assumed they would b

Set to `false` to disable minification, or specify the minifier to use. The default is [esbuild](https://github.com/evanw/esbuild) which is 20 ~ 40x faster than terser and only 1 ~ 2% worse compression. [Benchmarks](https://github.com/privatenumber/minification-benchmarks)

Note the `build.minify` option does not minify whitespaces when using the `'es'` format in lib mode, as it removes pure annotations and breaks tree-shaking.
Note the `build.minify` option does not minify whitespaces when using the `'es'` format in lib mode, as it removes pure annotations and breaks tree-shaking. To force whitespace minification for `'es'` format in lib mode, explicitly set `esbuild.minifyWhitespace` to `true`.

Terser must be installed when it is set to `'terser'`.

Expand Down
2 changes: 1 addition & 1 deletion packages/vite/src/node/__tests__/plugins/esbuild.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ describe('resolveEsbuildTranspileOptions', () => {
minify: false,
minifyIdentifiers: true,
minifySyntax: true,
minifyWhitespace: false,
minifyWhitespace: true,
treeShaking: true,
supported: {
'dynamic-import': true,
Expand Down
2 changes: 1 addition & 1 deletion packages/vite/src/node/plugins/esbuild.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ export function resolveEsbuildTranspileOptions(
minify: false,
minifyIdentifiers: options.minifyIdentifiers ?? true,
minifySyntax: options.minifySyntax ?? true,
minifyWhitespace: false,
minifyWhitespace: options.minifyWhitespace ?? false,
treeShaking: true,
}
} else {
Expand Down
Loading