Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow enabling esbuild.minifyWhitespace for es format in lib mode (fix #6555) #18737

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

WIStudent
Copy link

@WIStudent WIStudent commented Nov 22, 2024

Description

To produce es bundles that can be tree-shaken, lib mode disables minifyWhitespace by default when using the es format. But there are cases where we want an es bundle that is as small as possible and that does not need to be tree-shakable. This change allows esbuild.minifyWhitespace to be re-enabled if the user so desires.

fixes #6555

fix vitejs#6555)

To produce es bundles that can be tree-shaken, lib mode disables
minifyWhitespace by default when using the es format. But there are
cases where we want an es bundle that is as small as possible and that
does not need to be tree-shakable. This change allows minifyWhitespace
to be re-enabled if the user so desires.
@WIStudent WIStudent changed the title fix: Allow enabling esbuild.minifyWhitespace for es format in lib mode (fix #6555) fix: allow enabling esbuild.minifyWhitespace for es format in lib mode (fix #6555) Nov 22, 2024
@WIStudent WIStudent mentioned this pull request Nov 22, 2024
4 tasks
@sapphi-red sapphi-red added the p2-to-be-discussed Enhancement under consideration (priority) label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-to-be-discussed Enhancement under consideration (priority)
Projects
Status: Discussing
Development

Successfully merging this pull request may close these issues.

Lib mode format: es.min
2 participants