Fix multiple error snackbars not showing

lib/ui/list/item_list.dart

@@ -274,7 +274,7 @@ abstract class ItemList<
       },
       child: RefreshIndicator(
         onRefresh: () async {
-          BlocProvider.of<K>(context).add(ReloadItemList());
+          BlocProvider.of<K>(context).add(const ReloadItemList());
         },
         child: BlocBuilder<K, ItemListState>(
           builder: (BuildContext context, ItemListState state) {
@@ -293,7 +293,7 @@ abstract class ItemList<
               return ItemError(
                 title: AppLocalizations.of(context)!.somethingWentWrongString,
                 onRetryTap: () =>
-                    BlocProvider.of<K>(context).add(ReloadItemList()),
+                    BlocProvider.of<K>(context).add(const ReloadItemList()),
               );
             }
 
@@ -447,7 +447,7 @@ abstract class ItemListBody<T extends PrimaryModel,
         arguments: DetailArguments<T>(
           item: item,
           onChange: () {
-            BlocProvider.of<K>(context).add(ReloadItemList());
+            BlocProvider.of<K>(context).add(const ReloadItemList());
           },
         ),
       );

logic/lib/bloc/calendar_manager/calendar_manager_bloc.dart

@@ -13,5 +13,9 @@ class CalendarManagerBloc
     Emitter<CalendarManagerState> emit,
   ) {
     emit(CalendarNotLoaded(event.error, event.errorDescription));
+
+    emit(
+      CalendarManagerInitialised(),
+    );
   }
 }

logic/lib/bloc/item_detail_manager/item_detail_manager_bloc.dart

@@ -133,6 +133,10 @@ abstract class ItemDetailManagerBloc<T extends PrimaryModel, N extends Object,
     Emitter<ItemDetailManagerState> emit,
   ) {
     emit(ItemDetailNotLoaded(event.error, event.errorDescription));
+
+    emit(
+      ItemDetailManagerInitialised(),
+    );
   }
 
   void _handleError(Object e, Emitter<ItemDetailManagerState> emit) {

logic/lib/bloc/item_list/item_list_bloc.dart

@@ -20,7 +20,6 @@ abstract class ItemListBloc<T extends PrimaryModel, N extends Object,
   }) : super(ItemListLoading()) {
     on<LoadItemList>(_mapLoadToState);
     on<ReloadItemList>(_mapReloadToState);
-    on<UpdateItemList<T>>(_mapUpdateListToState);
     on<UpdateView>(_mapUpdateViewToState);
     on<UpdatePage>(_mapUpdatePageToState);
     on<UpdateStyle>(_mapUpdateStyleToState);
@@ -50,9 +49,11 @@ abstract class ItemListBloc<T extends PrimaryModel, N extends Object,
       final int viewIndex = (state as ItemListLoaded<T>).viewIndex;
       final ListStyle style = (state as ItemListLoaded<T>).style;
 
-      emit(
-        ItemListLoading(),
-      );
+      if (!event.silent) {
+        emit(
+          ItemListLoading(),
+        );
+      }
 
       try {
         final List<T> items = await getAllWithView(viewIndex);
@@ -90,20 +91,6 @@ abstract class ItemListBloc<T extends PrimaryModel, N extends Object,
     }
   }
 
-  void _mapUpdateListToState(
-    UpdateItemList<T> event,
-    Emitter<ItemListState> emit,
-  ) {
-    emit(
-      ItemListLoaded<T>(
-        event.items,
-        event.viewIndex,
-        event.page,
-        event.style,
-      ),
-    );
-  }
-
   void _mapUpdateViewToState(
     UpdateView event,
     Emitter<ItemListState> emit,
@@ -198,11 +185,11 @@ abstract class ItemListBloc<T extends PrimaryModel, N extends Object,
   }
 
   void _mapAddedToEvent(ItemAdded<T> managerState) {
-    add(ReloadItemList());
+    add(const ReloadItemList(silent: true));
   }
 
   void _mapDeletedToEvent(ItemDeleted<T> managerState) {
-    add(ReloadItemList());
+    add(const ReloadItemList(silent: true));
   }
 
   @override

logic/lib/bloc/item_list/item_list_event.dart

@@ -1,9 +1,5 @@
 import 'package:equatable/equatable.dart';
 
-import 'package:game_oclock_client/api.dart' show PrimaryModel;
-
-import 'package:logic/model/model.dart' show ListStyle;
-
 abstract class ItemListEvent extends Equatable {
   const ItemListEvent();
 
@@ -13,30 +9,17 @@ abstract class ItemListEvent extends Equatable {
 
 class LoadItemList extends ItemListEvent {}
 
-class ReloadItemList extends ItemListEvent {}
+class ReloadItemList extends ItemListEvent {
+  const ReloadItemList({this.silent = false});
 
-class UpdateItemList<T extends PrimaryModel> extends ItemListEvent {
-  const UpdateItemList(
-    this.items,
-    this.viewIndex,
-    this.page,
-    this.style,
-  );
-
-  final List<T> items;
-  final int viewIndex;
-  final int page;
-  final ListStyle style;
+  final bool silent;
 
   @override
-  List<Object> get props => <Object>[items, viewIndex, page, style];
+  List<Object> get props => <Object>[silent];
 
   @override
-  String toString() => 'UpdateItemList { '
-      'items: $items, '
-      'viewIndex: $viewIndex, '
-      'page: $page, '
-      'style: $style'
+  String toString() => 'ReloadItemList { '
+      'silent: $silent'
       ' }';
 }
 

logic/lib/bloc/item_list_manager/item_list_manager_bloc.dart

@@ -71,6 +71,10 @@ abstract class ItemListManagerBloc<T extends PrimaryModel, N extends Object,
     Emitter<ItemListManagerState> emit,
   ) {
     emit(ItemListNotLoaded(event.error, event.errorDescription));
+
+    emit(
+      ItemListManagerInitialised(),
+    );
   }
 
   Future<T> _create(AddItem<N> event) {

logic/lib/bloc/item_relation_manager/item_relation_manager_bloc.dart

@@ -70,6 +70,10 @@ abstract class ItemRelationManagerBloc<W extends PrimaryModel, N extends Object>
     Emitter<ItemRelationManagerState> emit,
   ) {
     emit(ItemRelationNotLoaded(event.error, event.errorDescription));
+
+    emit(
+      ItemRelationManagerInitialised(),
+    );
   }
 
   @protected

logic/lib/bloc/review_manager/review_manager_bloc.dart

@@ -12,5 +12,9 @@ class ReviewManagerBloc extends Bloc<ReviewManagerEvent, ReviewManagerState> {
     Emitter<ReviewManagerState> emit,
   ) {
     emit(ReviewNotLoaded(event.error, event.errorDescription));
+
+    emit(
+      ReviewManagerInitialised(),
+    );
   }
 }

logic/lib/bloc/server_settings_manager/server_settings_manager_bloc.dart

@@ -62,7 +62,6 @@ class ServerSettingsManagerBloc
   ) {
     emit(ServerSettingsNotLoaded(event.error, event.errorDescription));
 
-    // TODO Check others missing initialised
     emit(
       ServerSettingsManagerInitialised(),
     );