Fix label and unnecessary loading indicator

viplmad · Feb 5, 2024 · 48c5d75 · 48c5d75
1 parent a285225
commit 48c5d75
Show file tree

Hide file tree

Showing 6 changed files with 24 additions and 8 deletions.
diff --git a/lib/l10n/app_en.arb b/lib/l10n/app_en.arb
@@ -4,6 +4,7 @@
   "connectString": "Connect",
   "failedConnectionString": "Failed connection",
   "retryString": "Retry",
+  "reloadString": "Reload",
   "changeRepositoryString": "Change connection settings",
   "changeStartGameViewString": "Change start Game View",
   "startGameViewString": "Start Game View",

diff --git a/lib/l10n/app_es.arb b/lib/l10n/app_es.arb
@@ -4,6 +4,7 @@
   "connectString": "Conectar",
   "failedConnectionString": "Conexión fallida",
   "retryString": "Reintentar",
+  "reloadString": "Recargar",
   "changeRepositoryString": "Cambiar ajustes de conexión",
   "changeStartGameViewString": "Cambiar vista de juegos inicial",
   "startGameViewString": "Vista de juegos inicial",

diff --git a/lib/ui/detail/item_detail.dart b/lib/ui/detail/item_detail.dart
@@ -193,7 +193,7 @@ abstract class ItemDetailBody<
   }
 
   void reloadItem(BuildContext context) {
-    BlocProvider.of<K>(context).add(ReloadItem());
+    BlocProvider.of<K>(context).add(const ReloadItem());
     reloadExtraFields(context);
   }
 

diff --git a/lib/ui/relation/item_relation.dart b/lib/ui/relation/item_relation.dart
@@ -262,7 +262,7 @@ class _RelationList extends StatelessWidget {
                 text: headerText,
                 trailingWidget: IconButton(
                   icon: const Icon(Icons.refresh),
-                  tooltip: AppLocalizations.of(context)!.retryString,
+                  tooltip: AppLocalizations.of(context)!.reloadString,
                   onPressed: reload,
                 ),
               ),

diff --git a/logic/lib/bloc/item_detail/item_detail_bloc.dart b/logic/lib/bloc/item_detail/item_detail_bloc.dart
@@ -44,9 +44,11 @@ abstract class ItemDetailBloc<T extends PrimaryModel, N extends Object,
     Emitter<ItemDetailState> emit,
   ) async {
     if (state is ItemLoaded<T>) {
-      emit(
-        ItemLoading(),
-      );
+      if (!event.silent) {
+        emit(
+          ItemLoading(),
+        );
+      }
 
       await _mapAnyLoadToState(emit);
     } else if (state is! ItemLoading) {
@@ -85,11 +87,11 @@ abstract class ItemDetailBloc<T extends PrimaryModel, N extends Object,
   }
 
   void _mapFieldUpdatedToEvent(ItemFieldUpdated event) {
-    add(ReloadItem());
+    add(const ReloadItem(silent: true));
   }
 
   void _mapImageUpdatedToEvent(ItemImageUpdated event) {
-    add(ReloadItem());
+    add(const ReloadItem(silent: true));
   }
 
   @override

diff --git a/logic/lib/bloc/item_detail/item_detail_event.dart b/logic/lib/bloc/item_detail/item_detail_event.dart
@@ -9,4 +9,16 @@ abstract class ItemDetailEvent extends Equatable {
 
 class LoadItem extends ItemDetailEvent {}
 
-class ReloadItem extends ItemDetailEvent {}
+class ReloadItem extends ItemDetailEvent {
+  const ReloadItem({this.silent = false});
+
+  final bool silent;
+
+  @override
+  List<Object> get props => <Object>[silent];
+
+  @override
+  String toString() => 'ReloadItem { '
+      'silent: $silent'
+      ' }';
+}