Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't use react-streaming when SSR is disabled #34

Merged
merged 1 commit into from
Nov 18, 2023
Merged

fix: don't use react-streaming when SSR is disabled #34

merged 1 commit into from
Nov 18, 2023

Conversation

lourot
Copy link
Contributor

@lourot lourot commented Nov 17, 2023

Follow-up on #33
CC @nitedani

@nitedani
Copy link
Member

Thank you!

@brillout brillout merged commit 6c7c38a into main Nov 18, 2023
6 checks passed
@brillout
Copy link
Member

@AurelienLourot I made you co-admin of the vike-react package; feel free to publish a new version if you feel like this patch is worth a new version. The script is $ pnpm run release.

@lourot lourot deleted the aurelien/fix/react-streaming branch November 18, 2023 11:26
@lourot
Copy link
Contributor Author

lourot commented Nov 18, 2023

yay, thanks, released as 0.3.4

@brillout
Copy link
Member

🎉

@lourot lourot mentioned this pull request Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lourot @nitedani @brillout