only stream page-view

[phonzammi]

resolve #36

Please take a look and review

[lourot]

Thanks a lot for doing this @phonzammi. Did you also validate that now useId() produces the same ID on server and on client?

[phonzammi]

Thanks a lot for doing this @phonzammi.

No problem

Did you also validate that now useId() produces the same ID on server and on client?

Yes, I did

[phonzammi]

Before moving on, I have some thing to discuss, sorry, this might be a bit long:

Below condition can bit tricky at some point:

const isSsrDisabled = !pageContext.Page
const page = isSsrDisabled ? <></> : getPageElement(pageContext)

const streamOrString = isSsrDisabled ? dangerouslySkipEscape(renderToString(page)) : await renderToStream(page, { userAgent: pageContext.userAgent })

• !pageContext.page mean ssr disabled is true

But, we don't really check if is it stream: httpResponse.pipe(res), or not (which is : res.status(statusCode).send(body)) we actually enforces users to use ssr with streaming or no ssr at all.
That means if users created their on server.js and they use res.status(statusCode).send(body), it just won't work and they will get an error.

I don't have any fix yet, but still digging

[brillout]

That is indeed a concern, I created a new ticket for it: #38. Let's tackle it in an another PR.

If this PR is LGTM for Aurelien, then I'd suggest we merge this.

[lourot]

Published as v0.3.5