Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert machine part id #482

Merged
merged 15 commits into from
Apr 18, 2024
Merged

Conversation

cheukt
Copy link
Member

@cheukt cheukt commented Apr 17, 2024

after getting a sense of the problem, machine part id is likely not the best path forward

@cheukt cheukt added ready-for-protos add this when you want protos to compile on every commit safe to test committer is a member of this org labels Apr 17, 2024
@cheukt cheukt removed protos-compiled safe to test committer is a member of this org ready-for-protos add this when you want protos to compile on every commit labels Apr 17, 2024
@abe-winter abe-winter added ready-for-protos add this when you want protos to compile on every commit enhancement New feature or request and removed enhancement New feature or request labels Apr 17, 2024
@github-actions github-actions bot added the safe to test committer is a member of this org label Apr 17, 2024
@abe-winter abe-winter added the enhancement New feature or request label Apr 17, 2024
@abe-winter abe-winter removed ready-for-protos add this when you want protos to compile on every commit enhancement New feature or request labels Apr 17, 2024
@cheukt cheukt added the ready-for-protos add this when you want protos to compile on every commit label Apr 17, 2024
@abe-winter abe-winter removed the ready-for-protos add this when you want protos to compile on every commit label Apr 18, 2024
@cheukt
Copy link
Member Author

cheukt commented Apr 18, 2024

@stevebriskin can you merge?

@abe-winter abe-winter merged commit 274901d into viamrobotics:main Apr 18, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protos-compiled safe to test committer is a member of this org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants