-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert machine part id #482
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheukt
added
ready-for-protos
add this when you want protos to compile on every commit
safe to test
committer is a member of this org
labels
Apr 17, 2024
cheukt
removed
protos-compiled
safe to test
committer is a member of this org
ready-for-protos
add this when you want protos to compile on every commit
labels
Apr 17, 2024
abe-winter
added
ready-for-protos
add this when you want protos to compile on every commit
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Apr 17, 2024
abe-winter
removed
ready-for-protos
add this when you want protos to compile on every commit
enhancement
New feature or request
labels
Apr 17, 2024
cheukt
added
the
ready-for-protos
add this when you want protos to compile on every commit
label
Apr 17, 2024
ale7714
approved these changes
Apr 18, 2024
abe-winter
removed
the
ready-for-protos
add this when you want protos to compile on every commit
label
Apr 18, 2024
@stevebriskin can you merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after getting a sense of the problem, machine part id is likely not the best path forward