RSDK-7258: change status to message type in board api #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martha-johnston
requested review from
a team and
susmitaSanyal
and removed request for
a team
susmitaSanyal
approved these changes
Apr 18, 2024
martha-johnston
added
ready-for-protos
martha-johnston
removed
the
ready-for-protos
martha-johnston
added
the
ready-for-protos
martha-johnston
commented
Apr 22, 2024
| common.v1.BoardStatus status = 1; | ||
| message Status { | ||
| map<string, viam.common.v1.AnalogStatus> analogs = 1; | ||
| map<string, viam.common.v1.DigitalInterruptStatus> digital_interrupts = 2; |
There was a problem hiding this comment.
it's part of the scope to remove Analog and Digital statuses, however it is breaking app. I think it's fixable, but it requires changes to the TS sdk and the TS sdk cannot be tested until these api changes are merged. I'd like to start with this non-breaking merge and then update typescript and then come back and make the final api change to remove the analog and digital statuses. thoughts @susmitaSanyal
martha-johnston
added
ready-for-protos
|
@Simberific do you have to merge this since it's breaking? If it's someone else let me know! |
martha-johnston
added
protos-compiled
and removed
ready-for-protos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.