-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSDK-7307: Update Status for Board in Python SDK #586
Conversation
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
Looks reasonable for now, but should be considered a draft until viamrobotics/api#479 is merged |
marking as ready for review so that this is hopefully ready to merge once the rdk changes get approved, but I won't merge until api is merged |
2c20df6
to
dd5ecd9
Compare
@njooma @purplenicole730 do either of you know why these test might be failing? it seems unrelated to my change so wondering if you've seen it before. |
Not your fault, but you have to add an unimplemented function in RobotService. The function is |
src/viam/components/board/client.py
Outdated
self._analog_reader_names: Optional[List[str]] = None | ||
self._digital_interrupt_names: Optional[List[str]] = None | ||
self._analog_reader_names: List[str] = [] | ||
self._digital_interrupt_names: List[str] = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay I was having a test issue and couldn't figure out how to resolve it without making these not optional. how much of a problem is that/does anyone know a better resolution?
Co-authored-by: Naveed Jooma <[email protected]>
No description provided.