Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-7307: Update Status for Board in Python SDK #586

Merged
merged 9 commits into from
Apr 24, 2024

Conversation

martha-johnston
Copy link
Contributor

No description provided.

Copy link
Contributor

Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!

component function
base is_moving
board gpio_pin_by_name
camera get_image
encoder get_position
motor is_moving
sensor get_readings
servo get_position
arm get_end_position
gantry get_lengths
gripper is_moving
movement_sensor get_linear_acceleration
input_controller get_controls
audio get_properties
pose_tracker get_poses
power_sensor get_power
motion get_pose
vision get_classifications_from_camera

@njooma
Copy link
Member

njooma commented Apr 15, 2024

Looks reasonable for now, but should be considered a draft until viamrobotics/api#479 is merged

@martha-johnston martha-johnston marked this pull request as draft April 15, 2024 15:52
@martha-johnston martha-johnston marked this pull request as ready for review April 19, 2024 13:52
@martha-johnston
Copy link
Contributor Author

marking as ready for review so that this is hopefully ready to merge once the rdk changes get approved, but I won't merge until api is merged

@martha-johnston
Copy link
Contributor Author

@njooma @purplenicole730 do either of you know why these test might be failing? it seems unrelated to my change so wondering if you've seen it before.

@njooma
Copy link
Member

njooma commented Apr 23, 2024

@njooma @purplenicole730 do either of you know why these test might be failing? it seems unrelated to my change so wondering if you've seen it before.

Not your fault, but you have to add an unimplemented function in RobotService. The function is RestartModule

self._analog_reader_names: Optional[List[str]] = None
self._digital_interrupt_names: Optional[List[str]] = None
self._analog_reader_names: List[str] = []
self._digital_interrupt_names: List[str] = []
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay I was having a test issue and couldn't figure out how to resolve it without making these not optional. how much of a problem is that/does anyone know a better resolution?

@martha-johnston martha-johnston merged commit 0f0dcb8 into viamrobotics:main Apr 24, 2024
6 of 12 checks passed
njooma added a commit to njooma/viam-python-sdk that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants