Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSDK-8342] Bump Viam Python SDK dep and fix bug I found along the way #57

Merged
merged 2 commits into from
Sep 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Keep the below block the same as requirements.txt
depthai==2.26.0
viam-sdk==0.25.2
viam-sdk==0.29.3
Pillow==10.4.0
opencv-python==4.10.0.84
numpy>=1.23,<2.0.0 # >2.0.0 breaks depthai https://github.com/luxonis/depthai-viewer/releases/tag/v0.2.3
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
depthai==2.26.0
viam-sdk==0.25.2
viam-sdk==0.29.3
Pillow==10.4.0
opencv-python==4.10.0.84
numpy>=1.23,<2.0.0 # >2.0.0 breaks depthai https://github.com/luxonis/depthai-viewer/releases/tag/v0.2.3
Expand Down
4 changes: 2 additions & 2 deletions src/components/worker/worker.py
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ def configure_ydn(color_nodes: List[dai.node.ColorCamera]):
configure_ydn(color_nodes)

self.logger.info("Successfully configured pipeline.")
except ViamError as e:
except Exception as e:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DepthAI SDK does not throw ViamErrors lol

msg = f"Error configuring pipeline at stage '{stage}'. Note the error following this log"
resolution_err_substr = "bigger than maximum at current sensor resolution"
calibration_err_substr = "no Camera data available"
Expand All @@ -348,7 +348,7 @@ async def start(self):
self.device = dai.Device(self.pipeline)
self.device.startPipeline()
self.logger.debug("Successfully initialized device.")
except ViamError as e:
except Exception as e:
self.logger.error(f"Error initializing device: {e}")
await asyncio.sleep(1)

Expand Down
1 change: 0 additions & 1 deletion src/components/worker/worker_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
import threading

from src.components.worker.worker import Worker
from viam.logging import getLogger
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import



class AtomicBoolean:
Expand Down
Loading