[RSDK-8342] Bump Viam Python SDK dep and fix bug I found along the way #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexbabe
changed the title
hexbabe
commented
Sep 3, 2024
| @@ -327,7 +327,7 @@ def configure_ydn(color_nodes: List[dai.node.ColorCamera]): | |||
| configure_ydn(color_nodes) | |||
|
|
|||
| self.logger.info("Successfully configured pipeline.") | |||
| except ViamError as e: | |||
| except Exception as e: | |||
There was a problem hiding this comment.
DepthAI SDK does not throw ViamErrors lol
hexbabe
commented
Sep 3, 2024
| @@ -2,7 +2,6 @@ | |||
| import threading | |||
|
|
|||
| from src.components.worker.worker import Worker | |||
| from viam.logging import getLogger | |||
randhid
approved these changes
Sep 3, 2024
|
Are you merging this in or closing it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RSDK-8342