Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate authentication.md to german #889

Merged
merged 37 commits into from
Nov 14, 2023
Merged

Translate authentication.md to german #889

merged 37 commits into from
Nov 14, 2023

Conversation

mezotv
Copy link
Contributor

@mezotv mezotv commented Aug 27, 2023

Adds the correct and finished German translation for the authentication.md file. Also fixes the index.de.md translation!

This is the complete and improved version of #827

@mezotv mezotv requested a review from a team as a code owner August 27, 2023 18:09
@mezotv
Copy link
Contributor Author

mezotv commented Aug 27, 2023

If I missed anything let me know and I will add that as soon as possible!

@mezotv
Copy link
Contributor Author

mezotv commented Aug 27, 2023

Hey @ptoffy would you be able to check this out?

ptoffy
ptoffy previously requested changes Aug 27, 2023
Copy link
Member

@ptoffy ptoffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed until line ~100 and have found quite some missing pieces. Please review the file and fix the pieces you can find, then I'm happy to fix the left overs! (If @mattesmohr isn't faster 😄)

docs/security/authentication.de.md Outdated Show resolved Hide resolved
docs/security/authentication.de.md Outdated Show resolved Hide resolved
docs/security/authentication.de.md Outdated Show resolved Hide resolved
docs/security/authentication.de.md Outdated Show resolved Hide resolved
docs/security/authentication.de.md Outdated Show resolved Hide resolved
docs/security/authentication.de.md Outdated Show resolved Hide resolved
docs/security/authentication.de.md Outdated Show resolved Hide resolved
docs/security/authentication.de.md Outdated Show resolved Hide resolved
docs/security/authentication.de.md Outdated Show resolved Hide resolved
docs/security/authentication.de.md Show resolved Hide resolved
@mezotv
Copy link
Contributor Author

mezotv commented Aug 27, 2023

I reviewed until line ~100 and have found quite some missing pieces. Please review the file and fix the pieces you can find, then I'm happy to fix the left overs! (If @mattesmohr isn't faster 😄)

Yea I didn't check the first half seems like matt left a bit out ill get that fixed!

@mezotv
Copy link
Contributor Author

mezotv commented Aug 27, 2023

@ptoffy I have added the necessary changes let me know if you find something!

@mezotv mezotv requested a review from ptoffy August 27, 2023 21:59
@mattesmohr mattesmohr added the translation-update This PR contains translations for the docs label Aug 28, 2023
@mattesmohr
Copy link
Member

mattesmohr commented Aug 28, 2023

Hiya Dominik, I hope you don't mind I hop in. Paul and I have talked and we think I should do the review, since I have started the initial translation for the authentication.md. First, thank you for taking the time to finish the translation. I appreciate it. I will take a look at least at the end of the week, as I write you in between two appointments right now and the rest of the week doesn't look different.

Since this is about the German translation, I think it is totally fine to express ourself in German.

Wie Paul schon anmerkt, werden sicherlich viele Schreibfehler in meinem Part der Übersetzung sein. Da ich alles mit der Hand schreibe und es mir im ersten Moment nur um das Abarbeiten von Passagen ging. Ich kann gerne nochmal über meinen Part drüber lesen. Musst du nicht machen.

Falls du deinen Teil durch eine LLM gejagt hast, könnte es sein, dass du "Du" als Anrede verwendest, während ich die Anrede "Wir" verwendet habe. Ich tue mir damit leichter den richtigen Ton zu treffen. Sollte das der Fall sein, müssen wir unsere beiden Übersetzungen in "Einklang" bringen. Welche Anrede wir verwenden ist mir dann egal. Hauptsache es ist einheitlich.

@mezotv
Copy link
Contributor Author

mezotv commented Aug 28, 2023

Hiya Dominik, I hope you don't mind I hope in. Paul and I have talked and we think I should do the review, since I have started the initial translation for the authentication.md. First, thank you for taking the time to finish the translation. I appreciate it. I will take a look at least at the end of the week, as I write you in between two appointments right now and the rest of the week doesn't look different.

Since this is about the German translation, I think it is totally fine to express ourself in German.

Wie Paul schon anmerkt, werden sicherlich viele Schreibfehler in meinem Part der Übersetzung sein. Da ich alles mit der Hand schreibe und es mir im ersten Moment nur um das Abarbeiten von Passagen ging. Ich kann gerne nochmal über meinen Part drüber lesen. Musst du nicht machen.

Falls du deinen Teil durch eine LLM gejagt hast, könnte es sein, dass du "Du" als Anrede verwendest, während ich die Anrede "Wir" verwendet habe. Ich tue mir damit leichter den richtigen Ton zu treffen. Sollte das der Fall sein, müssen wir unsere beiden Übersetzungen in "Einklang" bringen. Welche Anrede wir verwenden ist mir dann egal. Hauptsache es ist einheitlich.

Hört sich gut an du kannst dir gerne deinen teil nochmal durch lesen uns fehler beweben. Die anrede wäre mir egal "du" oder "wir" geht beides. Lass mich wissen was du davon besser findest dann änder ich es in meinem teil! Auch wenn die englische version beides benutzt.

@ptoffy
Copy link
Member

ptoffy commented Sep 25, 2023

Hey @mattesmohr, do you have any updates on this? :)

@mattesmohr
Copy link
Member

Hey @mattesmohr, do you have any updates on this? :)

Yes and no. I am back from vacation and I have some time to spare. Will finish the review this week.

Copy link
Member

@mattesmohr mattesmohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anbei die erste Hälfte des Reviews. Mehr habe ich heute nicht geschafft.

docs/index.de.md Outdated Show resolved Hide resolved
docs/security/authentication.de.md Show resolved Hide resolved
docs/security/authentication.de.md Outdated Show resolved Hide resolved
docs/security/authentication.de.md Outdated Show resolved Hide resolved
docs/security/authentication.de.md Outdated Show resolved Hide resolved
docs/security/authentication.de.md Outdated Show resolved Hide resolved
docs/security/authentication.de.md Outdated Show resolved Hide resolved
docs/security/authentication.de.md Outdated Show resolved Hide resolved
docs/security/authentication.de.md Outdated Show resolved Hide resolved
docs/security/authentication.de.md Outdated Show resolved Hide resolved
@mezotv
Copy link
Contributor Author

mezotv commented Oct 1, 2023

Anbei die erste Hälfte des Reviews. Mehr habe ich heute nicht geschafft.

Sehr cool danke! Leider hab ich kaum zeit mehr werde mir das ganze also erst mitte November anschauen können.

docs/security/authentication.de.md Outdated Show resolved Hide resolved
docs/security/authentication.de.md Outdated Show resolved Hide resolved
docs/security/authentication.de.md Outdated Show resolved Hide resolved
docs/security/authentication.de.md Outdated Show resolved Hide resolved
@mezotv
Copy link
Contributor Author

mezotv commented Nov 14, 2023

Any update on this @mattesmohr @ptoffy?

@mattesmohr
Copy link
Member

@mezotv Hiya, ich bin nicht ganz zufrieden, werde aber noch mit meiner Korrektur auf meiner Festplatte etwas brauchen. Ein, zwei Abschnitte sind noch übrig. Damit das PR mal erledigt wird, werde ich es, wenn die Test durchgelaufen und bestanden sind, nachher oder heute Abend mergen.

@mezotv mezotv closed this Nov 14, 2023
@mezotv mezotv reopened this Nov 14, 2023
@mattesmohr mattesmohr dismissed ptoffy’s stale review November 14, 2023 17:45

The review should be outdated by now.

@mattesmohr mattesmohr merged commit 798becd into vapor:main Nov 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation-update This PR contains translations for the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants