-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate authentication.md to german #889
Conversation
If I missed anything let me know and I will add that as soon as possible! |
Hey @ptoffy would you be able to check this out? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed until line ~100 and have found quite some missing pieces. Please review the file and fix the pieces you can find, then I'm happy to fix the left overs! (If @mattesmohr isn't faster 😄)
Yea I didn't check the first half seems like matt left a bit out ill get that fixed! |
Co-authored-by: Paul Toffoloni <[email protected]>
Co-authored-by: Paul Toffoloni <[email protected]>
Co-authored-by: Paul Toffoloni <[email protected]>
Co-authored-by: Paul Toffoloni <[email protected]>
Co-authored-by: Paul Toffoloni <[email protected]>
Co-authored-by: Paul Toffoloni <[email protected]>
Co-authored-by: Paul Toffoloni <[email protected]>
Co-authored-by: Paul Toffoloni <[email protected]>
Co-authored-by: Paul Toffoloni <[email protected]>
Co-authored-by: Paul Toffoloni <[email protected]>
@ptoffy I have added the necessary changes let me know if you find something! |
Hiya Dominik, I hope you don't mind I hop in. Paul and I have talked and we think I should do the review, since I have started the initial translation for the authentication.md. First, thank you for taking the time to finish the translation. I appreciate it. I will take a look at least at the end of the week, as I write you in between two appointments right now and the rest of the week doesn't look different. Since this is about the German translation, I think it is totally fine to express ourself in German. Wie Paul schon anmerkt, werden sicherlich viele Schreibfehler in meinem Part der Übersetzung sein. Da ich alles mit der Hand schreibe und es mir im ersten Moment nur um das Abarbeiten von Passagen ging. Ich kann gerne nochmal über meinen Part drüber lesen. Musst du nicht machen. Falls du deinen Teil durch eine LLM gejagt hast, könnte es sein, dass du "Du" als Anrede verwendest, während ich die Anrede "Wir" verwendet habe. Ich tue mir damit leichter den richtigen Ton zu treffen. Sollte das der Fall sein, müssen wir unsere beiden Übersetzungen in "Einklang" bringen. Welche Anrede wir verwenden ist mir dann egal. Hauptsache es ist einheitlich. |
Hört sich gut an du kannst dir gerne deinen teil nochmal durch lesen uns fehler beweben. Die anrede wäre mir egal "du" oder "wir" geht beides. Lass mich wissen was du davon besser findest dann änder ich es in meinem teil! Auch wenn die englische version beides benutzt. |
Hey @mattesmohr, do you have any updates on this? :) |
Yes and no. I am back from vacation and I have some time to spare. Will finish the review this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anbei die erste Hälfte des Reviews. Mehr habe ich heute nicht geschafft.
Sehr cool danke! Leider hab ich kaum zeit mehr werde mir das ganze also erst mitte November anschauen können. |
Co-authored-by: Mattes Mohr <[email protected]>
Co-authored-by: Mattes Mohr <[email protected]>
Co-authored-by: Mattes Mohr <[email protected]>
Co-authored-by: Mattes Mohr <[email protected]>
Co-authored-by: Mattes Mohr <[email protected]>
Co-authored-by: Mattes Mohr <[email protected]>
Co-authored-by: Mattes Mohr <[email protected]>
Co-authored-by: Mattes Mohr <[email protected]>
Co-authored-by: Mattes Mohr <[email protected]>
Co-authored-by: Mattes Mohr <[email protected]>
Co-authored-by: Mattes Mohr <[email protected]>
Co-authored-by: Mattes Mohr <[email protected]>
Co-authored-by: Mattes Mohr <[email protected]>
Co-authored-by: Mattes Mohr <[email protected]>
Any update on this @mattesmohr @ptoffy? |
@mezotv Hiya, ich bin nicht ganz zufrieden, werde aber noch mit meiner Korrektur auf meiner Festplatte etwas brauchen. Ein, zwei Abschnitte sind noch übrig. Damit das PR mal erledigt wird, werde ich es, wenn die Test durchgelaufen und bestanden sind, nachher oder heute Abend mergen. |
The review should be outdated by now.
Adds the correct and finished German translation for the authentication.md file. Also fixes the index.de.md translation!
This is the complete and improved version of #827