Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add German translation for authentication.md #827

Closed
wants to merge 2 commits into from
Closed

Add German translation for authentication.md #827

wants to merge 2 commits into from

Conversation

mattesmohr
Copy link
Member

It adds the German translation for authentication.md. It should be the last translation of the old branch.

@mattesmohr mattesmohr added the translation-update This PR contains translations for the docs label Jun 10, 2023
@0xTim
Copy link
Member

0xTim commented Jun 13, 2023 •
edited by mattesmohr
Loading

@mattesmohr is this good to go?

@mattesmohr
Copy link
Member Author

@mattesmohr is this good to go?

Not yet, I want to revise it a bit more.

I guess you can merge the other one. I think Jonas didn't have the time to look at it, but I think it is good to go.

@0xTim
Copy link
Member

0xTim commented Jun 13, 2023

@mattesmohr cool, want to mark them as draft until they're ready to go? I'll look at the other one

@mattesmohr
Copy link
Member Author

@mattesmohr cool, want to mark them as draft until they're ready to go? I'll look at the other one

Good idea. I will mark it, when I am home from work.

@Suboptimierer
Copy link
Member

I think Jonas didn't have the time to look at it, but I think it is good to go.

Sorry for the late reply, @mattesmohr! Unfortunately, I don't have time for that at the moment. But I'm happy to help you with the translations again in 4 weeks ✌🏻

@mattesmohr
Copy link
Member Author

I think Jonas didn't have the time to look at it, but I think it is good to go.

Sorry for the late reply, @mattesmohr! Unfortunately, I don't have time for that at the moment. But I'm happy to help you with the translations again in 4 weeks ✌🏻

No pressure. Everything is fine.

@mattesmohr mattesmohr marked this pull request as draft July 4, 2023 15:50
@ptoffy
Copy link
Member

ptoffy commented Aug 4, 2023

Hey @mattesmohr I'm fluent in German as I'm bilingual, I can review your translations too if @Suboptimierer can't make it! :)

@mattesmohr
Copy link
Member Author

Awesome. Good to know!

I am currently busy with customer projects that I couldn't find the time to translate it further. There are still English parts in it.

But I am eager to finish it as soon I have more time to spare.

@ptoffy
Copy link
Member

ptoffy commented Aug 4, 2023

Cool, feel free to ping me or assign me as reviewer when you're done with it

@mezotv mezotv mentioned this pull request Aug 27, 2023
Merged
@mattesmohr
Copy link
Member Author

I close the PR in favour of #889.

@mattesmohr mattesmohr closed this Sep 2, 2023
mattesmohr added a commit that referenced this pull request Nov 14, 2023
@mezotv @ptoffy
@0xTim @mattesmohr
Translate authentication.md to german (#889)
798becd 
Adds the correct and finished German translation for the
authentication.md file. Also fixes the index.de.md translation!

This is the complete and improved version of #827

---------

Co-authored-by: Paul Toffoloni <[email protected]>
Co-authored-by: Tim Condon <[email protected]>
Co-authored-by: Mattes Mohr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
draft translation-update This PR contains translations for the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattesmohr @0xTim @Suboptimierer @ptoffy