Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update a terrible function naming #29

Merged
merged 1 commit into from
Apr 19, 2024
Merged

chore: update a terrible function naming #29

merged 1 commit into from
Apr 19, 2024

Conversation

yangby-cryptape
Copy link
Contributor

@yangby-cryptape yangby-cryptape commented Apr 18, 2024 •
edited
Loading

Description

Yep!

If expect storage to generate a headers proof for on-chain headers, then storage has to contain more headers than on-chain.

It's a terrible function name. That's why you were confused.

I guess when I wrote this function, I think about the best SPV client should be included in storage, so I just wrote such a terrible name.

A best name should be find_best_spv_client_under_height.

Original post by comment in PR-25

@Flouse Flouse merged commit b9412ed into master Apr 19, 2024
5 checks passed
@Flouse Flouse deleted the chore/terrible-naming branch April 19, 2024 15:26
@Flouse Flouse mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EthanYuan EthanYuan EthanYuan approved these changes

@jjyr jjyr jjyr approved these changes

@Flouse Flouse Flouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yangby-cryptape @Flouse @jjyr @EthanYuan