Merge pull request #29 from ckb-cell/chore/terrible-naming

chore: update a terrible function naming
utxostack · Apr 19, 2024 · b9412ed · b9412ed
2 parents 0ab417f + c5b4a15
commit b9412ed
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/components/api_service/mod.rs b/src/components/api_service/mod.rs
@@ -268,7 +268,7 @@ impl SpvRpc for SpvRpcImpl {
         };
 
         let spv_client_cell = spv_instance
-            .find_best_spv_client_include_height(stg_tip_height)
+            .find_best_spv_client_not_greater_than_height(stg_tip_height)
             .map_err(|err| {
                 let message = format!(
                     "failed to get SPV cell base on height {stg_tip_height} from fetched data"

diff --git a/src/components/ckb_client.rs b/src/components/ckb_client.rs
@@ -79,7 +79,7 @@ pub trait CkbRpcClientExtension {
     ) -> Result<SpvClientCell> {
         let instance = self.find_spv_cells(spv_type_script)?;
         if let Some(height) = height_opt {
-            instance.find_best_spv_client_include_height(height)
+            instance.find_best_spv_client_not_greater_than_height(height)
         } else {
             instance.find_tip_spv_client()
         }
@@ -174,7 +174,10 @@ impl SpvInstance {
             .cloned()
     }
 
-    pub(crate) fn find_best_spv_client_include_height(&self, height: u32) -> Result<SpvClientCell> {
+    pub(crate) fn find_best_spv_client_not_greater_than_height(
+        &self,
+        height: u32,
+    ) -> Result<SpvClientCell> {
         let SpvInstance { ref info, clients } = self;
         let mut info = info.to_owned();
         for _ in 0..clients.len() {