Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: address shell script issues and re-enable shellcheck linting #401

Merged
merged 2 commits into from
Nov 14, 2024
Merged

chore: address shell script issues and re-enable shellcheck linting #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
671d0cb
chore: address shell script issues and re-enable shellcheck linting
smlx Oct 25, 2024
68423c2
Merge branch 'main' into shellcheck-actions
tobybellwood Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/lagoon-cli.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,15 +48,15 @@ jobs:
if: "!startsWith(github.ref, 'refs/tags/')"
id: version_tag_build
run: |
VERSION=$(echo $(git describe --abbrev=0 --tags)+$(git rev-parse --short=8 HEAD))
echo "VERSION=$VERSION" >> $GITHUB_ENV
VERSION="$(git describe --abbrev=0 --tags)+$(git rev-parse --short=8 HEAD)"
echo "VERSION=$VERSION" >> "$GITHUB_ENV"
echo "tag is $VERSION"
-
name: Set tag version for tag
if: "startsWith(github.ref, 'refs/tags/')"
id: version_tag
run: |
echo "VERSION=${GITHUB_REF#refs/tags/}" >> $GITHUB_ENV
echo "VERSION=${GITHUB_REF#refs/tags/}" >> "$GITHUB_ENV"
echo "tag is $VERSION"
-
name: Docker meta
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
- uses: docker://rhysd/actionlint:1.7.0@sha256:601d6faeefa07683a4a79f756f430a1850b34d575d734b1d1324692202bf312e # v1.7.0
with:
args: -color -shellcheck=
args: -color
6 changes: 3 additions & 3 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ jobs:
make test
- name: Compile CLI
run: |
make VERSION=${GITHUB_REF##*/} build-linux
make VERSION=${GITHUB_REF##*/} build-darwin
make VERSION="${GITHUB_REF##*/}" build-linux
make VERSION="${GITHUB_REF##*/}" build-darwin
# create the archived versions and remove anything not required for the release
rm ./builds/README.md ./builds/release_template.md
for BUILD in $(ls builds); do tar --transform="flags=r;s|${BUILD}|lagoon|" -czf builds/${BUILD}.tar.gz -C builds ${BUILD}; done
for BUILD in builds/*; do tar --transform="flags=r;s|${BUILD#builds/}|lagoon|" -czf "$BUILD.tar.gz" -C builds "${BUILD#builds/}"; done
- name: Generate SBOM from Github API
uses: advanced-security/sbom-generator-action@375dee8e6144d9fd0ec1f5667b4f6fb4faacefed # v0.0.1
id: sbom
Expand Down