Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: address shell script issues and re-enable shellcheck linting #401

Merged
merged 2 commits into from
Nov 14, 2024
Merged

chore: address shell script issues and re-enable shellcheck linting #401

merged 2 commits into from
Nov 14, 2024

Conversation

smlx
Copy link
Member

@smlx smlx commented Oct 25, 2024

No description provided.

@smlx smlx requested a review from tobybellwood October 25, 2024 02:32
@smlx smlx marked this pull request as ready for review October 25, 2024 02:32
tobybellwood
tobybellwood approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THis is a good template for how we can fix the other repos too

@tobybellwood tobybellwood merged commit 58f15bc into main Nov 14, 2024
7 checks passed
@tobybellwood tobybellwood deleted the shellcheck-actions branch November 14, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smlx @tobybellwood