a11y(arpa): fix headings and color contrast issues #3811
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,143 @@ | ||
| import LoginView from '@/arpa_reporter/views/LoginView.vue'; | ||
|
|
||
| import { | ||
| describe, it, afterEach, vi, expect, | ||
| } from 'vitest'; | ||
| import { | ||
| fireEvent, render, screen, cleanup, waitFor, | ||
| } from '@testing-library/vue'; | ||
|
|
||
| const mockPost = vi.fn(); | ||
| global.fetch = mockPost; | ||
|
|
||
| describe('LoginView component', () => { | ||
| const $route = { | ||
| query: {}, | ||
| }; | ||
|
|
||
| const mockRouter = { | ||
| push: vi.fn(), | ||
| resolve: vi.fn().mockReturnValue({ | ||
| href: '/arpa_reporter/', | ||
| }), | ||
| }; | ||
|
|
||
| afterEach(() => { | ||
| cleanup(); | ||
| vi.clearAllMocks(); | ||
| mockPost.mockClear(); | ||
| }); | ||
|
|
||
| it('it displays expected elements and handles successful login request', async () => { | ||
| mockPost.mockResolvedValueOnce( | ||
| new Promise((resolve) => { | ||
| resolve({ | ||
| ok: true, | ||
| success: true, | ||
| json: () => Promise.resolve({ message: 'Email sent to [email protected]. Check your inbox', success: true }), | ||
| }); | ||
| }), | ||
| ); | ||
|
|
||
| render(LoginView, { | ||
| global: { | ||
| mocks: { | ||
| $route, | ||
| $http: { post: mockPost }, | ||
| $router: mockRouter, | ||
| }, | ||
| }, | ||
| }); | ||
|
|
||
| screen.getByRole('heading', { name: /ARPA Reporter Login/i, level: 1 }); | ||
| const emailInput = screen.getByPlaceholderText(/email address/i); | ||
| const submitButton = screen.getByRole('button'); | ||
|
|
||
| await fireEvent.update(emailInput, '[email protected]'); | ||
| await fireEvent.click(submitButton); | ||
|
|
||
| await waitFor(() => screen.getByText(/Email sent to [email protected]. Check your inbox/i)); | ||
| }); | ||
|
|
||
| it('handles login error response', async () => { | ||
| mockPost.mockResolvedValueOnce( | ||
| new Promise((resolve) => { | ||
| resolve({ | ||
| ok: true, | ||
| success: true, | ||
| json: () => Promise.resolve({ message: 'User "[email protected]" not found', success: true }), | ||
| }); | ||
| }), | ||
| ); | ||
|
|
||
| render(LoginView, { | ||
| global: { | ||
| mocks: { | ||
| $route, | ||
| $http: { post: mockPost }, | ||
| $router: mockRouter, | ||
| }, | ||
| }, | ||
| }); | ||
|
|
||
| const emailInput = screen.getByPlaceholderText(/email address/i); | ||
| const submitButton = screen.getByRole('button'); | ||
|
|
||
| await fireEvent.update(emailInput, '[email protected]'); | ||
| await fireEvent.click(submitButton); | ||
|
|
||
| await waitFor(() => screen.getByText(/User "[email protected]" not found/i)); | ||
| }); | ||
|
|
||
| it('validates email format before submission', async () => { | ||
| render(LoginView, { | ||
| global: { | ||
| mocks: { | ||
| $route, | ||
| $http: { post: mockPost }, | ||
| $router: mockRouter, | ||
| }, | ||
| }, | ||
| }); | ||
|
|
||
| const emailInput = screen.getByPlaceholderText(/email address/i); | ||
| const submitButton = screen.getByRole('button'); | ||
|
|
||
| await fireEvent.update(emailInput, 'invalid-email'); | ||
| await fireEvent.click(submitButton); | ||
|
|
||
| expect(mockPost).not.toHaveBeenCalled(); | ||
| screen.getByText(/please enter a valid email/i); | ||
| }); | ||
| it('handles login error status', async () => { | ||
| mockPost.mockResolvedValueOnce( | ||
| new Promise((resolve) => { | ||
| resolve({ | ||
| ok: false, | ||
| success: true, | ||
| statusText: 'Unable to connect to the server', | ||
| status: 500, | ||
| json: () => Promise.resolve({ }), | ||
| }); | ||
| }), | ||
| ); | ||
|
|
||
| render(LoginView, { | ||
| global: { | ||
| mocks: { | ||
| $route, | ||
| $http: { post: mockPost }, | ||
| $router: mockRouter, | ||
| }, | ||
| }, | ||
| }); | ||
|
|
||
| const emailInput = screen.getByPlaceholderText(/email address/i); | ||
| const submitButton = screen.getByRole('button'); | ||
|
|
||
| await fireEvent.update(emailInput, '[email protected]'); | ||
| await fireEvent.click(submitButton); | ||
|
|
||
| await waitFor(() => screen.getByText(/login: Unable to connect to the server \(500\)/i)); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to reviewer: before/after screenshots
Before
After