a11y(arpa): fix headings and color contrast issues #3811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
QA Summary
Test CoverageCoverage report for `packages/client`
Coverage report for `packages/server`
|
lsr-explore
commented
Dec 16, 2024
| @@ -86,7 +86,7 @@ hr { | |||
| color: $positive-default; | |||
| } | |||
|
|
|||
| .usdr-tab-nav-link { | |||
| .usdr-link { | |||
There was a problem hiding this comment.
Note to reviewer: renamed the class to be general as it only contains color setting.
Terraform Summary
Hint: If "Terraform Format & Style" failed, run OutputValidation OutputPlan Summary
Pusher: @lsr-explore, Action: |
lsr-explore
force-pushed
the
chore/arpa-a11y-contrast-headings
branch
from
5dd82b9 to
3f8da5b
Compare
lsr-explore
changed the title
lsr-explore
force-pushed
the
chore/arpa-a11y-contrast-headings
branch
from
3f8da5b to
0b8830c
Compare
lsr-explore
commented
Dec 20, 2024
| @@ -5,7 +5,7 @@ | |||
| <div class="mb-4"> | |||
| <router-link | |||
| to="/agencies/new" | |||
| class="btn btn-primary" | |||
| class="btn usdr-btn-primary" | |||
There was a problem hiding this comment.
Note to reviewer:
Screenshots
Before
After
lsr-explore
commented
Dec 20, 2024
| @@ -16,7 +16,7 @@ | |||
| </div> | |||
| <div class="form-group"> | |||
| <button | |||
| class="btn btn-primary" | |||
| class="btn usdr-btn-primary" | |||
There was a problem hiding this comment.
Note to reviewer: screenshots
Before
- Color Contrast
- Missing H1 heading
After
lsr-explore
commented
Dec 20, 2024
| @@ -79,7 +79,7 @@ export default { | |||
| name: 'submit', | |||
| type: 'submit', | |||
| label: 'Submit', | |||
| inputClass: ['btn', 'btn-primary'], | |||
| inputClass: ['btn', 'usdr-btn-primary'], | |||
There was a problem hiding this comment.
Note to reviewer: Screenshots
Before
After
lsr-explore
commented
Dec 20, 2024
| @@ -97,7 +98,7 @@ | |||
| <div class="modal-footer"> | |||
| <button | |||
| type="button" | |||
| class="btn btn-primary" | |||
| class="btn usdr-btn-primary" | |||
There was a problem hiding this comment.
Note to reviewer: before/after screenshots
Before
Repeated for each row
After
Note: This finding will be addressed in a separate PR
lsr-explore
commented
Dec 20, 2024
| @@ -122,7 +122,7 @@ export default { | |||
| computed: { | |||
| revalidateBtnClass() { | |||
| return { | |||
| 'btn-primary': !this.commit, | |||
| 'usdr-btn-primary': !this.commit, | |||
There was a problem hiding this comment.
Note to reviewer: before/after screenshots
Before
After
lsr-explore
commented
Dec 20, 2024
| @@ -4,7 +4,7 @@ | |||
| <div class="mb-4"> | |||
| <router-link | |||
| to="/users/new" | |||
| class="btn btn-primary" | |||
| class="btn usdr-btn-primary" | |||
There was a problem hiding this comment.
Note to reviewer: before/after screenshots
Before
After
lsr-explore
commented
Dec 20, 2024
| @@ -1,6 +1,6 @@ | |||
| <template> | |||
| <div> | |||
| <h2>User</h2> | |||
| <h1>User</h1> | |||
There was a problem hiding this comment.
Note to reviewer: before/after screenshots
Color Contrast was resolved with change above to StandardForm.vue
Before
After
lsr-explore
commented
Dec 20, 2024
| @@ -59,7 +59,7 @@ | |||
| <div class="col-sm-2" /> | |||
| <div class="col-sm-10"> | |||
| <button | |||
| class="btn btn-primary" | |||
| class="btn usdr-btn-primary" | |||
There was a problem hiding this comment.
Note to reviewer: before/after screenshots
Before
After
lsr-explore
force-pushed
the
chore/arpa-a11y-contrast-headings
branch
from
a75ee31 to
46be599
Compare
lsr-explore
commented
Dec 21, 2024
| @@ -215,7 +218,7 @@ export default { | |||
| { | |||
| label: 'EC Code', | |||
| field: 'ec_code', | |||
| tdClass: (row) => (!row.ec_code ? 'table-danger' : undefined), | |||
| tdClass: (row) => (!row.ec_code ? 'usdr-table-danger' : undefined), | |||
There was a problem hiding this comment.
Note to reviewer: before/after screenshots
The following will be addressed in separate PRs
- Accessible name
- Table heard text should not be empty
Color Contrast - Before
Color Contrast - After
lsr-explore
force-pushed
the
chore/arpa-a11y-contrast-headings
branch
from
46be599 to
df092c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket #3758
(TBD - Will create a different ticket for the issues addressed here before requesting review)
Description
Address the following accessibility issues
(See comments associated with code file changes for screenshots)
Adding tests to improve the coverage for some of the ARPA views.
(TBD - will update more views before requesting review)
Before
After
Screenshots / Demo Video
See comments associated with code file changes before/after screenshots
Testing
Automated and Unit Tests
Manual tests for Reviewer
Checklist