Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add several architectures and their debian images #58

Open
wants to merge 35 commits into
base: master
Choose a base branch
from

Conversation

radimkohout
Copy link

@radimkohout radimkohout commented Nov 7, 2021

This pull request adds buster and bullseye Debian for riscv64, mips64le, i386, and amd64(I know, that i386 and amd64 you can use without this, but with this action, it is much easier to build several platforms.
Edit: after I've found, that the riscv64 has no stable and oldstable build's, I've changed riscv64 to experimental and unstable, I'll probably add more images soon.

@uraimo
Copy link
Owner

uraimo commented Nov 9, 2021

Hi, thanks, can you also add at least one new arch pair here for the new architectures to be sure that the emulation works? Thx.

@radimkohout
Copy link
Author

radimkohout commented Nov 9, 2021

Hi, it's done, you can see the result's here: https://github.com/GarnetOS/run-on-arch-action/actions/runs/1441155688 , only running the riscv64/unstable seems to crash on git, but I can't find why.
Edit: Amd64 and i386 fails on the thing, that "x86_64" != "amd64", and the asseratation fails on that.

@uraimo
Copy link
Owner

uraimo commented Nov 9, 2021

Unstable likely fails because git was not installed here, adding unstable to the options should fix it.
No idea about the other two, amd64 should not even use qemu-static to create the container, while that x86_64 is the name of static driver qemu has.

@radimkohout
Copy link
Author

radimkohout commented Nov 9, 2021

I'll try to address this issues in next few days, stay tuned for update 😃

@radimkohout
Copy link
Author

radimkohout commented Nov 18, 2021

Ok, all issues solved, things done to solve the issues:

  1. Added ENTRYPOINT ["linux32", "--"] to i386 Dockerfiles (see Linux personality (reported ex. via uname -m) is wrong ioft/dockerhub#1 ), also added note to the README "Contributing" part
  2. Added override to amd64(actually it's x86_64) and i386(actually i686).
  3. Added unstable override to "Assert container uses distro" for riscv64.

@radimkohout
Copy link
Author

Update: Added alpine_latest for i386 from #59

@uraimo
Copy link
Owner

uraimo commented Jan 4, 2022

After a few other PRs are merged, we'll merge this too, sorry for the delay, thanks again.

@radimkohout
Copy link
Author

Ok, thanks. I've already made a version for my private use, so don't worry. But I'll migrate here as soon as there will be a new version.

@megglos
Copy link

megglos commented Jun 1, 2022

After a few other PRs are merged, we'll merge this too, sorry for the delay, thanks again.

@uraimo Just wondered what the state of this PR is, it seems it was ready to merge but got stale? Is there anything still to resolve I could try to help with?

@martin-g
Copy link
Contributor

I also wanted to create an issue asking for adding x86_64/amd64 to the available architectures. It would be much easier to use the GHA matrix feature to test on both "native" arch (i.e. amd64) and non-native (emulated) ones. I see other people already had this idea!
Looking forward this PR to get some love soon and be merged!

@lalten
Copy link

lalten commented Oct 1, 2022

@uraimo what's the plan here? Anything still blocking this?

@uraimo
Copy link
Owner

uraimo commented Dec 23, 2022

Just an update on this, support for riscv64 has been added and a base_image parameter for completely custom images (any arch any distro) has been included in 2.5.0 that I've just tagged.

Since I was also planning to refactor the Dockerfile mechanism (too many files) in the next major release, that I would ideally complete next week, this PR will be reworked to become part of the new default images configuration, thanks to @radimkohout and all those that participated.

asdek added a commit to vxcontrol/rmx that referenced this pull request May 5, 2023
asdek added a commit to vxcontrol/rmx that referenced this pull request May 5, 2023
* feat: added arch i386 support

* fix: using another actions for i386 according to
uraimo/run-on-arch-action#58

* fix: using refs for actions link

* fix: refs to full commit version hash

* fix: changed base action image to own fork

* fix: arch typo 386 => i386
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.