-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(arch): arm64 image #214
Conversation
59772ef
to
7ea9119
Compare
- name: Publish image | ||
if: ${{ github.ref == 'refs/heads/next' || startsWith(github.ref, 'refs/heads/7.') }} | ||
run: ./release.sh | ||
env: | ||
DISTRO: ${{ matrix.DISTRO }} | ||
EE: false | ||
PLATFORMS: linux/arm64,linux/amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this just achieves making the final images pushed multiarch so the test pipeline is actually not making use of those, leaving the chance for undetected broken arm64 images.
Testing of each arch is a bit more tricky to achieve as we would need to also use qemu to test non amd64 images, something like https://github.com/uraimo/run-on-arch-action might be helpful, but this one doesn't support the amd64 arch yet, however they are working on it: uraimo/run-on-arch-action#58
9912ed7
to
3b669bf
Compare
When will this be merged? Would be great to have the arm image for the Apple Silicon. |
Waiting for this to get merged, the x86 image isn't usable on Apple Silicon |
closing as this will be done by the platform team |
WIP not ready yet.
Would resolve #205
Relates to #CAM-14301
See
https://docs.docker.com/buildx/working-with-buildx/#build-multi-platform-images
https://docs.docker.com/ci-cd/github-actions/
https://github.com/docker/setup-buildx-action#with-qemu