Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(arch): arm64 image #214

Closed
wants to merge 1 commit into from
Closed

feat(arch): arm64 image #214

wants to merge 1 commit into from

Conversation

megglos
Copy link

@megglos megglos commented Feb 12, 2022

@megglos megglos force-pushed the arm64 branch 16 times, most recently from 59772ef to 7ea9119 Compare February 12, 2022 11:52
- name: Publish image
if: ${{ github.ref == 'refs/heads/next' || startsWith(github.ref, 'refs/heads/7.') }}
run: ./release.sh
env:
DISTRO: ${{ matrix.DISTRO }}
EE: false
PLATFORMS: linux/arm64,linux/amd64
Copy link
Author

@megglos megglos Feb 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this just achieves making the final images pushed multiarch so the test pipeline is actually not making use of those, leaving the chance for undetected broken arm64 images.

Testing of each arch is a bit more tricky to achieve as we would need to also use qemu to test non amd64 images, something like https://github.com/uraimo/run-on-arch-action might be helpful, but this one doesn't support the amd64 arch yet, however they are working on it: uraimo/run-on-arch-action#58

@CLAassistant
Copy link

CLAassistant commented Mar 18, 2022

CLA assistant check
All committers have signed the CLA.

@ghost
Copy link

ghost commented Mar 31, 2022

When will this be merged? Would be great to have the arm image for the Apple Silicon.

@patrick-werner
Copy link

Waiting for this to get merged, the x86 image isn't usable on Apple Silicon

@megglos
Copy link
Author

megglos commented Dec 16, 2022

closing as this will be done by the platform team

@megglos megglos closed this Dec 16, 2022
@tmetzke tmetzke deleted the arm64 branch March 20, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants