Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed printing issues within monopoly.py #29

Closed
wants to merge 1 commit into from

Conversation

rehamansoor
Copy link

In the function refresh_h_and_s(), the program was not clearing the status section properly. The change was minor, but was able to fix the problem that was occurring with view artifact. When debugging the 4th part, I ran the program many times but was not able to replicate the error. That part seemed to be running properly.

@adamgulde adamgulde linked an issue Oct 5, 2024 that may be closed by this pull request
Copy link
Collaborator

@adamgulde adamgulde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the correct approach but the "3. Viewing deed text artifacts (3)" isn't fully fixed. Consider this unittest (which I think should be in the most current code, no one's been adding many unittests)
def unittest():
players[1].buy(1)
players[1].buy(3)
players[2].buy(5)
players[2].buy(15)
players[2].buy(25)
players[2].buy(35)
players[3].buy(12)
players[3].buy(28)

If, for example, I view deed # 3 (baltic avenue), then press p to manage properties for player 3 (for example), there will be still artifacts from viewing the deed. Please test your code further.

Also arguably more importantly, please see the updates I made to contributing.md (specifically steps 3-6). Your branch is far behind the main repo, so following those steps when you're ready to contribute will make the review process much faster.

@adamgulde adamgulde self-assigned this Oct 22, 2024
@adamgulde adamgulde closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Easy printing issues
2 participants