Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy printing issues #23

Open
adamgulde opened this issue Sep 27, 2024 · 4 comments
Open

Easy printing issues #23

adamgulde opened this issue Sep 27, 2024 · 4 comments
Assignees
Labels
bug Something isn't working correctly or something crashes the program easy Good for newcomers

Comments

@adamgulde
Copy link
Collaborator

A few more current printing issues need to be fixed. While you don't necessarily have to solve ALL of them, I think one person is capable of solving all of the following.

1. Viewing deed text artifacts

image
(crossed out text should be cleared)
Leftover text is visible when it should be cleared.
Steps to recreate:
Start a new game
When prompted to view a deed, press 'd' to view a deed. Doesn't matter what deed.
View another deed number that is invalid, for example #30 (jail).

2. Viewing deed text artifacts (2)

image
New text overwrites other text, but not necessarily all.
Steps to recreate:
When prompted to view a deed, press 'd' to view a deed.
View another deed that is a valid number. Depending on the length of the first deed's information (e.g. name), it will extend past the current deed's information.

3. Viewing deed text artifacts (3)

image
Old text is still visible when managing properties.
Steps to recreate:
View any deed.
Then, press 'p' to manage properties.

4. Need to refresh input area when incorrect command pressed (1)

image
Steps to recreate
Type an incorrect command

Add more here as you notice them

@adamgulde adamgulde added bug Something isn't working correctly or something crashes the program easy Good for newcomers labels Sep 27, 2024
@rehamansoor
Copy link

Hi, can I try to work on this problem?

@adamgulde
Copy link
Collaborator Author

Hi, can I try to work on this problem?

Assigned! Don't hesitate to reach out on discord if it's difficult to begin

@rehamansoor
Copy link

I think I was able to debug 1, 2, 4. I am currently trying to debug "3. Viewing deed text artifacts (3)"

@adamgulde adamgulde linked a pull request Oct 5, 2024 that will close this issue
@adamgulde
Copy link
Collaborator Author

update on this? @rehamansoor

@adamgulde adamgulde self-assigned this Oct 22, 2024
@adamgulde adamgulde linked a pull request Nov 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly or something crashes the program easy Good for newcomers
Projects
None yet
2 participants