Replace uf_common with mil_msgs for great merge compatibility #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is even happening to the world anymore. No more uf_common? But where will all the mess of software that you don't want to properly design for both systems but use on both systems go? jk it's time |
|
In @ironmig's comment, he references uf_common #15. He really meant to reference uf-mil/mil_common#15. Please excuse his mistake. |
|
This built on the CI and passed all unit tests except the ros_alarms test that always fails. It was tested with uf-mil/mil_common#28 and uf-mil/SubjuGator#216. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With new mil_common repo, some message files used in this repo will need to be updated to the new mil_common packages. Don't merge this until uf_common #15 is merged.