Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1832 - Trainsylvania map translations #2483

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Fix #1832 - Trainsylvania map translations #2483

merged 1 commit into from
Jan 24, 2024

Conversation

michaelmcleodnz
Copy link
Contributor

Proposed changes

Allow translations of the stations in the Trainsylvania Map, as per #1832.

Checklist

  • I have read the contribution guidelines.
  • I have linked any relevant existing issues/suggestions in the description above (include #??? in your description to reference an issue, where ??? is the issue number).
  • The pull request is requesting a merge into the develop branch.
  • N/A I have added necessary documentation (if appropriate).
  • N/A If I've added/modified/deleted a third-party system, I've updated the relevant license files.
  • Done I have added myself to the 'Community Contributors' section of csfieldguide/templates/appendices/contributors.html

Further comments

The SVG remains visually unaltered (unless the translations are applied, in which case the texts will be different lengths), but I removed some <tspan>s, added some ids, and left the altered parts on separate lines in the SVG file so they can be found and edited in the future if necessary.

Copy link
Contributor

@jimbonothing64 jimbonothing64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding translations here. Please merge this in when you're ready. Thanks again.

@jimbonothing64 jimbonothing64 added this pull request to the merge queue Jan 24, 2024
Merged via the queue into uccser:develop with commit 589c762 Jan 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants