Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace radio buttons for CMY/RGB colour mixers #2482

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Namespace radio buttons for CMY/RGB colour mixers #2482

merged 1 commit into from
Jan 24, 2024

Conversation

michaelmcleodnz
Copy link
Contributor

Proposed changes

Minor fix: The CMY and RGB colour mixers are meant to appear on the same page (5.5), but the radio buttons for both interactives have the same names and IDs, contrary to most other elements in those interactives. This pull request gives the radio buttons different names and IDs, consistent with other elements, so that clicking a radio button in one interactive doesn't produce unexpected behaviours in the other.

Checklist

  • I have read the contribution guidelines.
  • N/A I have linked any relevant existing issues/suggestions in the description above (include #??? in your description to reference an issue, where ??? is the issue number).
  • The pull request is requesting a merge into the develop branch.
  • N/A I have added necessary documentation (if appropriate).
  • N/A If I've added/modified/deleted a third-party system, I've updated the relevant license files.
  • Previously I have added myself to the 'Community Contributors' section of csfieldguide/templates/appendices/contributors.html

Copy link
Contributor

@jimbonothing64 jimbonothing64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great spot! These changes look good, merge it in when you're ready. Thanks!

@michaelmcleodnz
Copy link
Contributor Author

Hi James, I can't do these merges myself as I'm just a random member of the public (a teacher in Auckland) and don't have write-access to the repository. This applies to this pull request and to #2483.

@jimbonothing64
Copy link
Contributor

Apologies, that's correct. I'll merge them in now. Thanks again for contributing Michael!

@jimbonothing64 jimbonothing64 added this pull request to the merge queue Jan 24, 2024
Merged via the queue into uccser:develop with commit 3b81a95 Jan 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants