Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out run_daemon and move to library #829

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Factor out run_daemon and move to library #829

wants to merge 2 commits into from

Conversation

Anviking
Copy link

To make it easier to test oura daemon in #823, we found it practical to split

// src/bin/oura/daemon.rs
pub fn run(args: &Args) -> Result<(), Error>

into:

// src/daemon/mod.rs
pub fn run_daemon(config: ConfigRoot) -> Result<Daemon, Error>

// src/bin/oura/run_daemon.rs
pub fn run(args: &Args) -> Result<(), Error>

to be able to start the daemon with having to first write a temporary config file to disk.

@Anviking
Factor out run_daemon and move to library
dcdb0f4 
Factor out
```
pub fn run_daemon(config: ConfigRoot) -> Result<Daemon, Error>
```

from

```
pub fn run(args: &Args) -> Result<(), Error>
```

and move it to the library such that we can call it from tests.
@Anviking Anviking mentioned this pull request Nov 12, 2024
Merged
Anviking
Anviking commented Nov 12, 2024
View reviewed changes
src/bin/oura/run_daemon.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scarmuega scarmuega Awaiting requested review from scarmuega scarmuega is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Anviking