Tweak integration tests #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use random TCP ports - Use random output files - Use goldenfile (has the practical UPDATE_GOLDENFILES=1 flag)
Anviking
force-pushed
the
anviking/integration-test-tweaks
branch
from
348186c
to
f32dded
Compare
Merged
| let rt = Runtime::new().unwrap(); | ||
| let _ = rt.block_on(async move { | ||
| let addr = "127.0.0.1:4001".to_string(); | ||
| let port: u16 = random_free_port().unwrap(); |
| @@ -85,4 +85,6 @@ futures-util = "0.3" | |||
| bytes = "1.7.2" | |||
|
|
|||
| [dev-dependencies] | |||
| assert_cmd = "2" | |||
| goldenfile = "1.7.3" | |||
paweljakubas
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have put the first commit in a separate PR to oura txpipe#829
Targets #8
Example failure output with goldenfile
(the differing 11 and 12 are underscored)