Integration tests #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paweljakubas
force-pushed
the
paweljakubas/integration-tests
branch
from
fcd3018
to
c20c779
Compare
Anviking
reviewed
Nov 5, 2024
tests/hydra.rs
Outdated
Comment on lines
467
to
485
| fn hydra_oura_stdout_scenario_1() -> TestResult { | ||
| let tx_event = r#"{"event":"apply","point":{"hash":"84e657e3dd5241caac75b749195f78684023583736cc08b2896290ab","slot":7},"record":{"hex":"84a300d9010281825820f0a39560ea80ccc68e8dffb6a4a077c8927811f06c5d9058d0fa2d1a8d047d2000018282581d605e4e214a6addd337126b3a61faad5dfe1e4f14f637a8969e3a05eefd1a001e848082581d600d45f2b310a98e766cee2ab2f6756c91719bd7b35929cef058365b651a015ef3c00200a100d90102818258200f193a88190f6dace0a3db1e0e50797a6e28cd4b6e289260dc96b5a8d7934bf858401b13ee550f3167a1b94796f2a2f5e22d782d628336a7797c5b798f358fa564dbe92ea75a4e2449eb2cef59c097d8497545ef1e4ea441b88a481194323ae7c608f5f6"}}"#; | ||
| let events = vec![ | ||
| "PeerConnected".to_string(), | ||
| "PeerConnected".to_string(), | ||
| "Greetings".to_string(), | ||
| "HeadIsInitializing".to_string(), | ||
| "Committed".to_string(), | ||
| "Committed".to_string(), | ||
| "Committed".to_string(), | ||
| "HeadIsOpen".to_string(), | ||
| "TxValid".to_string(), | ||
| tx_event.to_string(), | ||
| "SnapshotConfirmed".to_string(), | ||
| "HeadIsClosed".to_string(), | ||
| "ReadyToFanout".to_string(), | ||
| "HeadIsFinalized".to_string(), | ||
| ]; | ||
| hydra_oura_stdout_test("tests/hydra/scenario_1.txt".to_string(), events) |
There was a problem hiding this comment.
I tried mutating the expectations: tweaking 1) tx binary, 2) tx event slot, 3) dropping an event, but the test appears to still pass
There was a problem hiding this comment.
now it signals when failing. nice catch.thanks
Anviking
reviewed
Nov 5, 2024
Anviking
reviewed
Nov 5, 2024
tests/hydra.rs
Outdated
| predicates.push(predicate_fn.eval(json)); | ||
| count += 1; | ||
| } | ||
| assert_eq!(predicates, vec![true; expected.len()]); |
There was a problem hiding this comment.
Off the top of my head, I find it odd that the oura_pipeline is responsible for both capturing the output and performing the assertion. Did you consider returning the captured outputs in the result?
And — maybe we could check the output with something like goldenfile instead of assert_eq if the output is deterministic? 🤔
There was a problem hiding this comment.
added golden as suggested 👍
refining testing plus gitignore spawn cmd process and fix typo truncate log file make sure result of tests is taken into account clean redundant tests
paweljakubas
force-pushed
the
paweljakubas/integration-tests
branch
from
981030d
to
ab725ec
Compare
- Use random TCP ports - Use random output files - Use goldenfile (has the practical UPDATE_GOLDENFILES=1 flag)
Merged
Tweak integration tests
Anviking
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two suites of tests to be added.
Here we use dedicated daemon.toml which produces json. Every run it is truncated to 0, but one can inspect how it looks like ->
tests/hydra/logs.txt