Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple cov refactor bjs #1011

Open
wants to merge 327 commits into
base: master
Choose a base branch
from
Open

Simple cov refactor bjs #1011

wants to merge 327 commits into from

Conversation

bensjsilverstein
Copy link

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please describe):

Problem/feature

What problem are you trying to solve?
Methods were exceeding 7 lines

Solution

How did you solve the problem?
Refactored code and added helper methods and tests

Other changes (e.g. bug fixes, UI tweaks, small refactors)

Checklist

  • Code compiles correctly
  • Tests for the changes have been added (for bug fixes/features)
  • All tests passing
  • Extended the README / documentation, if necessary

brycesimonds and others added 30 commits June 4, 2022 10:47
@brycesimonds
Refactor: added expect to try and achieve 100% test coverage
6b47aeb
@brycesimonds
test: ran simplecov and got 96.8% coverage
2c3c3d9
@brycesimonds
Feat: added the class
6e14894
@brycesimonds
Test: added exists test
af15bc2
@brycesimonds
Feat: initialized InvoiceItem
f9c7e68
@brycesimonds
Debug: changed require invoice item from class to the .rb file
d0f074b
@brycesimonds
Test: added has attributes test, AND passed test at same time
5579f1d
@brycesimonds
Test: test for unit price to dollars method
83f6fb3
@brycesimonds
Feat: added unit price to dollars method
6220746
@Ethan-t-n
add initial test and code for invoice repo
9813775
@brycesimonds
Feat: added additional .rb files
b5e518c
@Ethan-t-n
add initial test for invoice
933436e
@brycesimonds
Debug: re-working SalesEngine initialize
40f1c81
@brycesimonds
Debug: try to get SalesEngine to work
b8b9fb8
@bensjsilverstein
Feat - add 'average_item_price_for_merchant' test
46e1844
@Ethan-t-n
add invoice class
dd0d0f6
@brycesimonds
Feat: made item_repo_data variable in from_csv method
2ec09f3
@brycesimonds
Debug: go back to original sales_engine rb
e9f1c27
@bensjsilverstein
Feat - Add 'average_item_price_for_merchant' method
b658227
@bensjsilverstein
Test - add 'average_items_per_merchant_standard_deviation' test
058f699
@bensjsilverstein
Feat - Add 'average_items_per_merchant_standard_deviaiton' method
10b97f4
@bensjsilverstein
Fix - convert unit_price method to float
0779406
@bensjsilverstein
Test - Add 'merchants_with_high_item_count' test
3420de1
@bensjsilverstein
Feat - Add 'merchants_with_high_item_count' method
68bd4e7
@sdecesari
Merge pull request #9 from Ethan-t-n/sales_analyst_tests_methods2_bjs
4d9dbfb 
Sales analyst tests methods2 bjs
@brycesimonds
Test: added it exists test
b43f658
@brycesimonds
Debug: corrected the it exists test
468fb3c
@brycesimonds
Feat: created an instance of InvoiceItemRepo.
9fe0023
@brycesimonds
Test: added test for all invoice item instances and opy and pasted si…
a53970f 
…miliar tests from other spec files
@brycesimonds
Debug: added require invoice item at top and edited the argument for …
7bf2d10 
…a new instance
sdecesari and others added 30 commits June 8, 2022 11:09
@sdecesari
Remove octothorpes
b8d252a
@sdecesari
Update x and c varaible names
2b57fe6
@sdecesari
Remove octothorpes
71a6451
@sdecesari
Remove octothorpes
c67ac0c
@sdecesari
Remove octothorpes
fa01892
@sdecesari
Update x and ii variable names
0e482e6
@sdecesari
Remove extra lines
f748dc5
@sdecesari
Remove extra lines
41b9be2
@sdecesari
Remove pry
aefd3c8
@sdecesari
Fix syntax remove octothorpes
b98330d
@brycesimonds
Debug: trying to get top_days_by_invoice_count to work
fc6489b
@sdecesari
Update x and t variable names
c84fa9a
@Ethan-t-n
Merge pull request #26 from Ethan-t-n/refactor_bgs
cfa2107 
Refactor bgs
@Ethan-t-n
Merge pull request #27 from Ethan-t-n/refactor_all-sd
6215d84 
Refactor all sd
@bensjsilverstein
Add - updated 'require_relative' statements to include:
5435f58 
invoice, invoice_repository
@bensjsilverstein
Test - Add 'top_days_by_invoice_count' test
02b3e0f
@bensjsilverstein
Feat - Add 'top_days_by_invoice_count' method
3c34626
@sdecesari
Merge pull request #28 from Ethan-t-n/top_days_by_invoice_count_bjs
3616cec 
Top days by invoice count bjs
@bensjsilverstein
Test - unskipped tests, added helper method tests
3775b98
@bensjsilverstein
Fix - Refactor 'invoice' status method with helper methods
c7b01c4
@bensjsilverstein
Fix - Refactor 'invoice_paid_in_full'
adf3d62
@bensjsilverstein
Fix - Refactor 'invoice_total(invoice_id)'
4b21ec3
@bensjsilverstein
Fix - Refactor 'merchants_with_high_item_count'
20b35d6
@bensjsilverstein
Fix - Refactor 'price_std_dev'
702b477
@bensjsilverstein
Fix - Refactor 'price_std_dev' 2
47fdb16
@bensjsilverstein
Test - Add helper method test for:
1805a42 
'average_invoices_per_merchant_standard_deviation'
@bensjsilverstein
Fix - Refactor 'average_invoices_per_merchant_standard_deviation'
96ff6eb 
Add helper method 'merchant ids'
@bensjsilverstein
Fix - Refactor 'top_days_by_invoice_count'
3c83cae
@bensjsilverstein
Fix - Add additional test for methods:
24a0334 
merchants, items, invoices, invoice_items, transactions, customers
@bensjsilverstein
Fix - remove 's' from @item_repository
395d1ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bensjsilverstein @brycesimonds @Ethan-t-n @sdecesari