Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Top days by invoice count bjs #1010

Open
wants to merge 314 commits into
base: master
Choose a base branch
from
Open

Top days by invoice count bjs #1010

wants to merge 314 commits into from

Conversation

bensjsilverstein
Copy link

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please describe):

Problem/feature

What problem are you trying to solve?

Solution

How did you solve the problem?

Other changes (e.g. bug fixes, UI tweaks, small refactors)

Added 'top_days_by_invoice_count' test and method , with helper methods

Checklist

  • Code compiles correctly
  • Tests for the changes have been added (for bug fixes/features)
  • All tests passing
  • Extended the README / documentation, if necessary

sdecesari and others added 30 commits June 3, 2022 08:46
@sdecesari
Simplecov update
ce2eaa5
@bensjsilverstein
Merge pull request #6 from Ethan-t-n/feat/simplecov-sd
e5d0742 
Feat/simplecov sd

BenS Review:
PR #6
Ran SimpleCov - observed 100% coverage (NICE) - change approved
Coverage files added - change approved
@sdecesari
Add exists test
3ba7a90
@sdecesari
Add analyst method
a0cbb4c
@sdecesari
Add non-working initialize
2a7f70d
@Ethan-t-n
Merge pull request #7 from Ethan-t-n/feat/iteration1-sd
3065773 
Feat/iteration1 sd
@bensjsilverstein
Add 'entry.rb' file to track require statements for class files
2c1c2c1
@bensjsilverstein
Fix - spacing adjusted
5728d09
@bensjsilverstein
Test - add 'exists' and 'average_items' test for SalesAnalyst
4428c3b
@bensjsilverstein
Feat - add 'average_items_per_merchant' method
e60ad0b
@bensjsilverstein
Fix - Adjust require statement, adjust SalesAnalys argument
7931d9b
@Ethan-t-n
Merge pull request #8 from Ethan-t-n/sales_analyst_tests_methods_bjs
4067901 
Sales analyst tests methods bjs
@brycesimonds
Refactor: changed description of test to show average items per merchant
9a72bbd
@brycesimonds
Refactor: added expect to try and achieve 100% test coverage
6b47aeb
@brycesimonds
test: ran simplecov and got 96.8% coverage
2c3c3d9
@brycesimonds
Feat: added the class
6e14894
@brycesimonds
Test: added exists test
af15bc2
@brycesimonds
Feat: initialized InvoiceItem
f9c7e68
@brycesimonds
Debug: changed require invoice item from class to the .rb file
d0f074b
@brycesimonds
Test: added has attributes test, AND passed test at same time
5579f1d
@brycesimonds
Test: test for unit price to dollars method
83f6fb3
@brycesimonds
Feat: added unit price to dollars method
6220746
@Ethan-t-n
add initial test and code for invoice repo
9813775
@brycesimonds
Feat: added additional .rb files
b5e518c
@Ethan-t-n
add initial test for invoice
933436e
@brycesimonds
Debug: re-working SalesEngine initialize
40f1c81
@brycesimonds
Debug: try to get SalesEngine to work
b8b9fb8
@bensjsilverstein
Feat - add 'average_item_price_for_merchant' test
46e1844
@Ethan-t-n
add invoice class
dd0d0f6
@brycesimonds
Feat: made item_repo_data variable in from_csv method
2ec09f3
sdecesari and others added 30 commits June 7, 2022 20:15
@sdecesari
Remove x from methods and refactor to single line code
6c7d4d6
@brycesimonds
Merge pull request #23 from Ethan-t-n/refactor_all=sd
e43d237 
Refactor all=sd
@sdecesari
Remove extra lines
f3c0d1e
@sdecesari
Remove extra lines
ee641da
@sdecesari
Remove extra lines
f32d8b0
@sdecesari
Remove extra lines
d9340af
@brycesimonds
Feat: invoice status method complete
d4c1fa7
@Ethan-t-n
Merge pull request #25 from Ethan-t-n/debug_bgs
691ce77 
Debug_bgs
@brycesimonds
Merge branch 'master' into refactor_all-sd
a85be74
@brycesimonds
Merge pull request #24 from Ethan-t-n/refactor_all-sd
08e862c 
Refactor all sd
@sdecesari
Change code to single line
11a012d
@brycesimonds
Feat: got array of invoice instances with created at turned to days o…
b4771d0 
…f the week (Sunday, etc)
@brycesimonds
Feat: added super to initialize
21500ff
@sdecesari
Remove octothorpes
b8d252a
@sdecesari
Update x and c varaible names
2b57fe6
@sdecesari
Remove octothorpes
71a6451
@sdecesari
Remove octothorpes
c67ac0c
@sdecesari
Remove octothorpes
fa01892
@sdecesari
Update x and ii variable names
0e482e6
@sdecesari
Remove extra lines
f748dc5
@sdecesari
Remove extra lines
41b9be2
@sdecesari
Remove pry
aefd3c8
@sdecesari
Fix syntax remove octothorpes
b98330d
@brycesimonds
Debug: trying to get top_days_by_invoice_count to work
fc6489b
@sdecesari
Update x and t variable names
c84fa9a
@Ethan-t-n
Merge pull request #26 from Ethan-t-n/refactor_bgs
cfa2107 
Refactor bgs
@Ethan-t-n
Merge pull request #27 from Ethan-t-n/refactor_all-sd
6215d84 
Refactor all sd
@bensjsilverstein
Add - updated 'require_relative' statements to include:
5435f58 
invoice, invoice_repository
@bensjsilverstein
Test - Add 'top_days_by_invoice_count' test
02b3e0f
@bensjsilverstein
Feat - Add 'top_days_by_invoice_count' method
3c34626
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bensjsilverstein @sdecesari @Ethan-t-n @brycesimonds