Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug bgs #1002

Open
wants to merge 286 commits into
base: master
Choose a base branch
from
Open

Debug bgs #1002

wants to merge 286 commits into from

Conversation

brycesimonds
Copy link

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please describe):

Problem/feature

What problem are you trying to solve?

Solution

How did you solve the problem?

Other changes (e.g. bug fixes, UI tweaks, small refactors)

Checklist

  • Code compiles correctly
  • Tests for the changes have been added (for bug fixes/features)
  • All tests passing
  • Extended the README / documentation, if necessary

Ethan-t-n and others added 30 commits June 2, 2022 09:58
@Ethan-t-n
add_price_to_dollar
9830779
@Ethan-t-n
add item repository initial test
3ac8f34
@Ethan-t-n
add class and inital spec test for item repository
5cf51a2
@Ethan-t-n
add .all method and .all test
044cf02
@Ethan-t-n
add can find id
1fabddf
@Ethan-t-n
refactor merchant repository
486b0a8
@Ethan-t-n
add test for find by id and find by name
978bddd
@Ethan-t-n
add test for find_all_with_description
42c3864
@Ethan-t-n
add test for find item by price
77fc04f
@Ethan-t-n
refactor finds item by price
94644c0
@Ethan-t-n
add test for find by merchant id
a28d33d
@Ethan-t-n
add test for create attributes
9ee2ab3
@Ethan-t-n
refactor merchant repository and add add method for item repo
f3ae5ea
@Ethan-t-n
add test for update
4af5e6a
@Ethan-t-n
add test for time in update test
3f388a9
@Ethan-t-n
fix name for update test
73ae959
@Ethan-t-n
add test for delete
d545a25
@Ethan-t-n
add method for delete
914cd6f
@brycesimonds
Merge pull request #4 from Ethan-t-n/add_item_tests_methods_en
ad35682 
Add item tests methods en
@sdecesari
Coverage file
cf4dd71
@sdecesari
File coverage
449dfb7
@brycesimonds
Test: Added it exists test
911b3db
@brycesimonds
Test: Added require CSV
a1a5fbb
@brycesimonds
Feat: SalesEngine does exit
f3c147a
@brycesimonds
Test: can return an array of all items
ace4221
@brycesimonds
Test: can return an array of all merchants
695d9fb
@sdecesari
Merge pull request #5 from Ethan-t-n/feat/add_sales_engine_and_tests
f0adf87 
Feat/add sales engine and tests
@sdecesari
Merge branch 'master' of github.com:Ethan-t-n/black_thursday
6fb7fbb
@sdecesari
Simplecov update
ce2eaa5
@bensjsilverstein
Merge pull request #6 from Ethan-t-n/feat/simplecov-sd
e5d0742 
Feat/simplecov sd

BenS Review:
PR #6
Ran SimpleCov - observed 100% coverage (NICE) - change approved
Coverage files added - change approved
bensjsilverstein and others added 30 commits June 7, 2022 16:51
@bensjsilverstein
Fix - change vairable name
bdc147d
@bensjsilverstein
Fix - change variable name
696bf19
@Ethan-t-n
add idea for sales analyst
dc39e99
@brycesimonds
Merge pull request #18 from Ethan-t-n/variable_rename1_bjs
c1c8e42 
Variable rename1 bjs
@bensjsilverstein
Merge pull request #19 from Ethan-t-n/feat/add_in_sales_analyest_en
1691c23 
PR #19
'in_invoice_total' method added - change approved
@bensjsilverstein
Fix - Refactor 'create' method Fix - update variable naming
8474f95
@bensjsilverstein
Fix - update variable naming, refactor create method
1194324
@bensjsilverstein
Refactor - update variable naming
260e506
@bensjsilverstein
Test - add 'average_invoices_per_merchant' test
3a173f4
@bensjsilverstein
Fix - updated test to use @ variable in before :each statement
3461813
@bensjsilverstein
Feat - add 'average_invoices_per_merchant_standard_deviation' method
39bb8a1
@bensjsilverstein
Test - Add 'average_invoices_per_merchant_standard_deviation' test
7768a62
@bensjsilverstein
Refactor - Adjust spacing
9b439bb
@bensjsilverstein
Feat - Add 'average_invoices_per_merchant_standard_deviation' method
7f66a11
@bensjsilverstein
Test - Add 'top_merchants_by_invoice_count' test
e469eff
@bensjsilverstein
Feat - Add 'top_merchants_by_invoice_count' method
37af5cf
@bensjsilverstein
Test - Add 'bottom_merchants_by_invoice_count' test
0218985
@brycesimonds
completed invoice total method
921ddc4
@Ethan-t-n
Merge pull request #20 from Ethan-t-n/finish_iteration_3_methods_bgs
3ecee62 
completed invoice total method
@bensjsilverstein
Fix - adjust bottom_merchants_by_invoice_count test methods
81b86c7
@bensjsilverstein
Feat - Add 'bottom_merchants_by_invoice_count' method
41b055e
@bensjsilverstein
Feat - update require_relative statement with new spec files
0bb50bd
@brycesimonds
Merge branch 'master' into iteration2_bjs
b484b01
@brycesimonds
Merge pull request #21 from Ethan-t-n/iteration2_bjs
3a562cb 
Iteration2 bjs
@sdecesari
Remove x from methods
115b971
@bensjsilverstein
SimpleCov bug fix
11b2b57
@sdecesari
Merge pull request #22 from Ethan-t-n/SimpleCov_bugfix_bjs
e22c56f 
SimpleCov bug fix
@sdecesari
Remove x from methods
2f7e488
@brycesimonds
Merge pull request #23 from Ethan-t-n/refactor_all=sd
e43d237 
Refactor all=sd
@brycesimonds
Feat: invoice status method complete
d4c1fa7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brycesimonds @Ethan-t-n @sdecesari @bensjsilverstein