Skip to content

firmware_update: rockusb_fwudate #52

firmware_update: rockusb_fwudate

firmware_update: rockusb_fwudate #52

GitHub Actions / clippy failed Oct 18, 2023 in 0s

clippy

2 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 2
Warning 0
Note 0
Help 0

Versions

  • rustc 1.73.0 (cc66ad468 2023-10-03)
  • cargo 1.73.0 (9c4383fb5 2023-08-26)
  • clippy 0.1.73 (cc66ad4 2023-10-03)

Annotations

Check failure on line 226 in src/app/bmc_application.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `std::collections::hash_map::Keys<'_, (u16, u16), std::boxed::Box<dyn for<'a> std::ops::Fn(&'a rusb::Device<rusb::GlobalContext>) -> std::pin::Pin<std::boxed::Box<dyn futures::Future<Output = std::result::Result<std::boxed::Box<dyn firmware_update::transport::FwUpdateTransport>, firmware_update::FwUpdateError>> + std::marker::Send>> + std::marker::Send + std::marker::Sync>>`

error: useless conversion to the same type: `std::collections::hash_map::Keys<'_, (u16, u16), std::boxed::Box<dyn for<'a> std::ops::Fn(&'a rusb::Device<rusb::GlobalContext>) -> std::pin::Pin<std::boxed::Box<dyn futures::Future<Output = std::result::Result<std::boxed::Box<dyn firmware_update::transport::FwUpdateTransport>, firmware_update::FwUpdateError>> + std::marker::Send>> + std::marker::Send + std::marker::Sync>>`
   --> src/app/bmc_application.rs:226:57
    |
226 |         self.configure_node_for_fwupgrade(node, router, SUPPORTED_DEVICES.keys().into_iter())
    |                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `SUPPORTED_DEVICES.keys()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `-D clippy::useless-conversion` implied by `-D warnings`

Check failure on line 63 in src/firmware_update/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variant `DeviceNotFound` is never constructed

error: variant `DeviceNotFound` is never constructed
  --> src/firmware_update/mod.rs:63:5
   |
61 | pub enum FwUpdateError {
   |          ------------- variant in this enum
62 |     #[error("Device {0:#06x}:{1:#06x} not found")]
63 |     DeviceNotFound(u16, u16),
   |     ^^^^^^^^^^^^^^
   |
   = note: `FwUpdateError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
   = note: `-D dead-code` implied by `-D warnings`