firmware_update: rockusb_fwudate #52
svenrademakersAnnotations
3 errors and 8 warnings
|
useless conversion to the same type: `std::collections::hash_map::Keys<'_, (u16, u16), std::boxed::Box<dyn for<'a> std::ops::Fn(&'a rusb::Device<rusb::GlobalContext>) -> std::pin::Pin<std::boxed::Box<dyn futures::Future<Output = std::result::Result<std::boxed::Box<dyn firmware_update::transport::FwUpdateTransport>, firmware_update::FwUpdateError>> + std::marker::Send>> + std::marker::Send + std::marker::Sync>>`:
src/app/bmc_application.rs#L226
error: useless conversion to the same type: `std::collections::hash_map::Keys<'_, (u16, u16), std::boxed::Box<dyn for<'a> std::ops::Fn(&'a rusb::Device<rusb::GlobalContext>) -> std::pin::Pin<std::boxed::Box<dyn futures::Future<Output = std::result::Result<std::boxed::Box<dyn firmware_update::transport::FwUpdateTransport>, firmware_update::FwUpdateError>> + std::marker::Send>> + std::marker::Send + std::marker::Sync>>`
--> src/app/bmc_application.rs:226:57
|
226 | self.configure_node_for_fwupgrade(node, router, SUPPORTED_DEVICES.keys().into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `SUPPORTED_DEVICES.keys()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
|
|
variant `DeviceNotFound` is never constructed:
src/firmware_update/mod.rs#L63
error: variant `DeviceNotFound` is never constructed
--> src/firmware_update/mod.rs:63:5
|
61 | pub enum FwUpdateError {
| ------------- variant in this enum
62 | #[error("Device {0:#06x}:{1:#06x} not found")]
63 | DeviceNotFound(u16, u16),
| ^^^^^^^^^^^^^^
|
= note: `FwUpdateError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
= note: `-D dead-code` implied by `-D warnings`
|
|
cargo-clippy
Clippy had exited with the 101 exit code
|
|
cargo-test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
cargo-test:
src/firmware_update/mod.rs#L63
variant `DeviceNotFound` is never constructed
|
|
cargo-test
`bmcd` (bin "bmcd" test) generated 1 warning
|
|
cargo-test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
cargo-test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
cargo-test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
cargo-test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
cargo-clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|