Prep DGMulti for non-conservative shock capturing
#1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hendrik Ranocha <[email protected]>
This reverts commit 7e0c458.
Co-authored-by: Hendrik Ranocha <[email protected]>
fix FToF naming
…to jc/gauss_shock_capturing
comments
This was inefficient since it didn't let us take advantage of sparsity.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1479 +/- ##
==========================================
- Coverage 89.67% 86.59% -3.08%
==========================================
Files 458 458
Lines 36400 36374 -26
==========================================
- Hits 32640 31496 -1144
- Misses 3760 4878 +1118
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ncons_for_shock_capturing
|
Shall this be merged before the next breaking release? |
|
I probably won't have time to finish this before then, so I'm happy to wait until the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should also improve efficiency and extend non-conservative terms to curved meshes.
#1478 should be merged first to reduce the size of this PR.