-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding non-conservative shock capturing for DGMulti
GaussSBP
#1480
Draft
jlchan
wants to merge
67
commits into
trixi-framework:main
Choose a base branch
from
jlchan:jc/noncons_shock_capturing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hendrik Ranocha <[email protected]>
This reverts commit 7e0c458.
Co-authored-by: Hendrik Ranocha <[email protected]>
fix FToF naming
…to jc/gauss_shock_capturing
comments
This was inefficient since it didn't let us take advantage of sparsity.
11 tasks
Codecov Report
@@ Coverage Diff @@
## main #1480 +/- ##
==========================================
+ Coverage 95.69% 95.72% +0.02%
==========================================
Files 359 361 +2
Lines 29779 29880 +101
==========================================
+ Hits 28497 28600 +103
+ Misses 1282 1280 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1478 and #1479 should be reviewed/merged first before merging this PR.