Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding non-conservative shock capturing for DGMulti GaussSBP #1480

Draft
wants to merge 67 commits into
base: main
Choose a base branch
from

Conversation

jlchan
Copy link
Contributor

@jlchan jlchan commented May 16, 2023

#1478 and #1479 should be reviewed/merged first before merging this PR.

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #1480 (4275293) into main (fa04120) will increase coverage by 0.02%.
The diff coverage is 96.43%.

@@            Coverage Diff             @@
##             main    #1480      +/-   ##
==========================================
+ Coverage   95.69%   95.72%   +0.02%     
==========================================
  Files         359      361       +2     
  Lines       29779    29880     +101     
==========================================
+ Hits        28497    28600     +103     
+ Misses       1282     1280       -2     
Flag Coverage Δ
unittests 95.72% <96.43%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/solvers/dgmulti/flux_differencing.jl 90.07% <96.00%> (+2.39%) ⬆️
src/solvers/dgmulti/shock_capturing.jl 92.52% <96.20%> (+2.01%) ⬆️
...s/dgmulti_2d/elixir_euler_shockcapturing_curved.jl 100.00% <100.00%> (ø)
...les/dgmulti_2d/elixir_mhd_shockcapturing_curved.jl 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants