Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get sudo-rs to compile on FreeBSD #869

Open
3 tasks done
squell opened this issue Oct 8, 2024 · 2 comments · May be fixed by #937
Open
3 tasks done

Get sudo-rs to compile on FreeBSD #869

squell opened this issue Oct 8, 2024 · 2 comments · May be fixed by #937
Labels
enhancement New feature or request freebsd

Comments

@squell
Copy link
Member

squell commented Oct 8, 2024 •
edited by bjorn3
Loading

You are allowed to cut corners here, e.g. disable some parts (preferably not too much).

This PR has a few easy intermediate steps:

  • sudo-rs compiles but doesn't actually work (i.e. crashes or does the wrong thing)
  • sudo-rs compiles and prints the help accurately
  • sudo-rs is able to launch a process (without any feature we actually care about such as authenticating the user properly, setting the timestamps, and so on)

Getting PAM and any other system interface working properly is a separate issue. The goal of this PR is to get a baseline.

Needless to say, this should not result in a PR on our current main, but rather something that lives in a (longer-lived) branch.

Don't forget to re-introduce the "Using this version of sudo-rs is likely to break your system" SUDO_RS_IS_UNSTABLE feature for this branch (or similar precaution)
@squell squell added enhancement New feature or request freebsd labels Oct 8, 2024
@squell
Copy link
Member Author

squell commented Oct 9, 2024

Note, if #862 is merged we already have a temporary "foolproof" since sudo wil refuse operation on FreeBSD.

@bjorn3
Copy link
Collaborator

bjorn3 commented Oct 9, 2024

The existing kernel_check already causes sudo-rs to refuse to run on FreeBSD.

This was referenced Oct 11, 2024
Merged
Merged
Merged
Merged
This was referenced Nov 4, 2024
Merged
Merged
This was referenced Nov 18, 2024
Merged
Merged
Merged
Merged
This was referenced Nov 25, 2024
Merged
Merged
This was referenced Dec 3, 2024
Merged
Merged
This was referenced Dec 16, 2024
Merged
Closed
@squell squell linked a pull request Dec 19, 2024 that will close this issue
Add effective group as the first element in the call to set groups #937
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request freebsd
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add effective group as the first element in the call to set groups trifectatechfoundation/sudo-rs
2 participants
@squell @bjorn3