Add effective group as the first element in the call to set groups
#937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squell
added
portability
freebsd
non-compliant
|
I have confirmed that b5f82b4 fixes the failure of sudo::flag_group::adds_group_to_groups_output and su::flag_group::when_specified_more_than_once_all_groups_are_added_to_group_list on FreeBSD. |
squell
force-pushed
the
freebsd-fix-groups
branch
from
c47f9da to
0ccfc1e
Compare
|
Much better than my PR :) |
This was referenced Dec 19, 2024
|
Still need to add a test for situations when the requested primary group id is already part of the group list. |
squell
force-pushed
the
freebsd-fix-groups
branch
from
b663634 to
ea08378
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my proposed alternative to PR #936. It's clear that inserting the effective group needs to happen at the start, not the end of the list; but the proposed solution there makes the rest of the policy module too dependent command line flags (and doesn't seem to solve the issue in case someone decides to use
-gto add the currently effective group).