testing: No longer silence deprecation warnings #3232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdarnell
force-pushed
the
undeprecate-event-loop-setting
branch
from
b18feb9 to
118b58f
Compare
|
I had a go at removing the filter that ignores deprecation warnings too, but then ran into those same test failures and quietly dropped it. Sorry if I gave a false impression of how ready #3223 was. |
bdarnell
force-pushed
the
undeprecate-event-loop-setting
branch
2 times, most recently
from
97e59c0 to
842fada
Compare
Only do it on the specific versions that had the problematic warnings. Also deprecate get_new_ioloop.
bdarnell
force-pushed
the
undeprecate-event-loop-setting
branch
from
842fada to
23f0aa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also deprecate get_new_ioloop.