Skip to content

Commit

Permalink
testing: No longer silence deprecation warnings
Browse files Browse the repository at this point in the history
Also deprecate get_new_ioloop.
  • Loading branch information
bdarnell committed Feb 16, 2023
1 parent d0132b5 commit b18feb9
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions tornado/testing.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,8 @@ class AsyncTestCase(unittest.TestCase):
By default, a new `.IOLoop` is constructed for each test and is available
as ``self.io_loop``. If the code being tested requires a
global `.IOLoop`, subclasses should override `get_new_ioloop` to return it.
reused global `.IOLoop`, subclasses should override `get_new_ioloop` to return it,
although this is deprecated as of Tornado 6.3.
The `.IOLoop`'s ``start`` and ``stop`` methods should not be
called directly. Instead, use `self.stop <stop>` and `self.wait
Expand Down Expand Up @@ -182,14 +183,9 @@ def __init__(self, methodName: str = "runTest") -> None:
self._test_generator = None # type: Optional[Union[Generator, Coroutine]]

def setUp(self) -> None:
setup_with_context_manager(self, warnings.catch_warnings())
warnings.filterwarnings(
"ignore",
message="There is no current event loop",
category=DeprecationWarning,
module=r"tornado\..*",
)
super().setUp()
if type(self).get_new_ioloop is not AsyncTestCase.get_new_ioloop:
warnings.warn("get_new_ioloop is deprecated", DeprecationWarning)
self.io_loop = self.get_new_ioloop()
asyncio.set_event_loop(self.io_loop.asyncio_loop) # type: ignore[attr-defined]

Expand Down Expand Up @@ -250,6 +246,9 @@ def get_new_ioloop(self) -> IOLoop:
singletons using the default `.IOLoop`) or if a per-test event
loop is being provided by another system (such as
``pytest-asyncio``).
.. deprecated:: 6.3
This method will be removed in Tornado 7.0.
"""
return IOLoop(make_current=False)

Expand Down

0 comments on commit b18feb9

Please sign in to comment.