Extended Support for Battery Detection and Display on WSL #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of straightforwardly calling `cat`, I've encased the command in `echo` to enable appending strings. This allows me to add a percentage symbol after calling `cat "$battery"`! This also suppresses any `echo`s for machines without battery (i.e. a desktop environment)
thekpaul
commented
Apr 24, 2023
This ensures that the script does not return errors when operating in environments without batteries, as if there are no battery-related files in the target directory, the script now stops from accessing the files to begin with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I'm back earlier than expected - check out #107 for an earlier version of this PR)
a. Check existence of battery-related directories or files whenever needed (
percentage,icon_statusandicon_charge)b. Default behaviour to "Charging" for Status, "Tier 8 (Fully Charged)" for Charge and
nullfor Percentage (Not printed)I've only made changes for percentage and icon display, so we may need to make more commits before everything else work seamlessly as well. In the meantime, I'd say that this is a minimal working PR for WSL environments both with and without batteries.