Use echo and Append Percentage Symbol on WSL
#107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thekpaul
changed the title
echo and Append Percentage Symbolecho and Append Percentage Symbol on WSL
Instead of straightforwardly calling `cat`, I've encased the command in `echo` to enable appending strings. This allows me to add a percentage symbol after calling `cat "$battery"`! This also suppresses any `echo`s for machines without battery (i.e. a desktop environment)
|
Something got messed up in the previous commit, so I refreshed the file locally and did a force push. The commits now appear as expected. |
|
There's a problem when working with wired WSL environments (i.e. a Windows desktop - gasp) where battery-related files are nonexistent to begin with. I'll be building on this commit to provide better return formats for these types of environments, and in the meantime, will be closing this pull request...but I'll be back ;) |
|
Check out #108 for an extended patch targeting WSL containing commits covered above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of straightforwardly calling
cat, I've encased the command inechoto enable appending strings. This allows me to add a percentage symbol after callingcat "$battery", like with other battery-related tools.This also suppresses any
echos for machines without battery (i.e. a desktop environment)