Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new routing graph for road shoulder #1456

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

HansRobo
Copy link
Member

@HansRobo HansRobo commented Nov 20, 2024

Description

Abstract

  • add new traffic rule germanRoadShoulderPassableVehicleRules
  • add new routing graph for VEHICLE_WITH_ROAD_SHOULDER
  • stop giving special treatment to shoulder_lanelet
    • delete HDMapUtils::getPreviousShoulderLaneletIds
    • delete HDMapUtils::getNextShoulderLaneletIds
  • add routing graph type argument
    • HDMapUtils::getPreviousLaneletIds
    • HDMapUtils::getNextLaneletIds
    • HDMapUtils::getRoute

Background

To get NPCs to work properly around the road shoulder, you need to create a routing graph that includes the road shoulder.

Details

routingWithRoadShoulder test

testing routing from 34693 to 34615 without lane changes.
(This case where you must go through road shoulder)

  • with default routing graph(VEHICLE): no route
  • with new routing graph(VEHICLE_WITH_ROAD_SHOULDER): has route

image

References

Destructive Changes

Although there have been some additions to function arguments, all of this has been carefully implemented to ensure backward compatibility.

Known Limitations

Copy link

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@HansRobo HansRobo added the bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 label Nov 25, 2024
@HansRobo HansRobo changed the title Add new traffic rule "germanRoadShoulderPassableVehicleRules" Add new traffic rule germanRoadShoulderPassableVehicleRules Nov 25, 2024
@HansRobo HansRobo changed the title Add new traffic rule germanRoadShoulderPassableVehicleRules Add new routing graph for road shoulder Nov 25, 2024
Copy link

sonarcloud bot commented Nov 25, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 wait for regression test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant