-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new routing graph for road shoulder #1456
Draft
HansRobo
wants to merge
13
commits into
master
Choose a base branch
from
feature/shoulder_routing_graph
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+161
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
…t to shoulder_lanelet in HdMapUtils::get{Next|Previous}LaneletIds
HansRobo
added
the
bump minor
If this pull request merged, bump minor version of the scenario_simulator_v2
label
Nov 25, 2024
HansRobo
changed the title
Add new traffic rule "germanRoadShoulderPassableVehicleRules"
Add new traffic rule Nov 25, 2024
germanRoadShoulderPassableVehicleRules
HansRobo
changed the title
Add new traffic rule
Add new routing graph for road shoulder
Nov 25, 2024
germanRoadShoulderPassableVehicleRules
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump minor
If this pull request merged, bump minor version of the scenario_simulator_v2
wait for regression test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
germanRoadShoulderPassableVehicleRules
VEHICLE_WITH_ROAD_SHOULDER
HDMapUtils::getPreviousShoulderLaneletIds
HDMapUtils::getNextShoulderLaneletIds
HDMapUtils::getPreviousLaneletIds
HDMapUtils::getNextLaneletIds
HDMapUtils::getRoute
Background
To get NPCs to work properly around the road shoulder, you need to create a routing graph that includes the road shoulder.
Details
routingWithRoadShoulder
testtesting routing from
34693
to34615
without lane changes.(This case where you must go through road shoulder)
VEHICLE
): no routeVEHICLE_WITH_ROAD_SHOULDER
): has routeReferences
Destructive Changes
Although there have been some additions to function arguments, all of this has been carefully implemented to ensure backward compatibility.
Known Limitations